All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: LABBE Corentin <clabbe.montjoie@gmail.com>,
	<computersforpeace@gmail.com>, <dwmw2@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] mtd: nand: atmel_nand: constify atmel_nand_caps structures
Date: Fri, 20 Nov 2015 16:28:10 +0800	[thread overview]
Message-ID: <564ED99A.2050502@atmel.com> (raw)
In-Reply-To: <1448005517-26004-2-git-send-email-clabbe.montjoie@gmail.com>

Hi, Corentin

Thanks for the patch.

On 11/20/2015 3:45 PM, LABBE Corentin wrote:
> All atmel_nand_caps are never modified, consitify them.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

Acked-by: Josh Wu <josh.wu@atmel.com>

Best Regards,
Josh Wu
> ---
>   drivers/mtd/nand/atmel_nand.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 583cdd9..475c938 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -128,7 +128,7 @@ struct atmel_nand_host {
>   
>   	struct atmel_nfc	*nfc;
>   
> -	struct atmel_nand_caps	*caps;
> +	const struct atmel_nand_caps	*caps;
>   	bool			has_pmecc;
>   	u8			pmecc_corr_cap;
>   	u16			pmecc_sector_size;
> @@ -2304,11 +2304,11 @@ static int atmel_nand_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static struct atmel_nand_caps at91rm9200_caps = {
> +static const struct atmel_nand_caps at91rm9200_caps = {
>   	.pmecc_correct_erase_page = false,
>   };
>   
> -static struct atmel_nand_caps sama5d4_caps = {
> +static const struct atmel_nand_caps sama5d4_caps = {
>   	.pmecc_correct_erase_page = true,
>   };
>   

  reply	other threads:[~2015-11-20  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  7:45 [PATCH v2 0/2] fix a possible NULL dereference LABBE Corentin
2015-11-20  7:45 ` LABBE Corentin
2015-11-20  7:45 ` [PATCH v2 1/2] mtd: nand: atmel_nand: constify atmel_nand_caps structures LABBE Corentin
2015-11-20  8:28   ` Josh Wu [this message]
2015-11-20 17:57     ` Brian Norris
2015-11-20  7:45 ` [PATCH v2 2/2] mtd: nand: atmel_nand: fix a possible NULL dereference LABBE Corentin
2015-11-20  8:33   ` Josh Wu
2015-11-24 13:12     ` LABBE Corentin
2015-11-25  2:20       ` Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564ED99A.2050502@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=clabbe.montjoie@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.