From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41911)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1ZzlzB-0005OE-IJ
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:44:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Zzlz7-000579-Do
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:44:21 -0500
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:35298 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Zzlz7-00055W-5G
	for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:44:17 -0500
Message-ID: <564F23AC.5030903@kamp.de>
Date: Fri, 20 Nov 2015 14:44:12 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1447932069-2772-1-git-send-email-quintela@redhat.com>
	<CAFEAcA_c72NNda-rAOcZK2e-tHwixOkYw38LFRfgTxZz42FPUQ@mail.gmail.com>
	<CAFEAcA9TiLAMxAsTgzo7PUyx_C72ya7iCHGjt-SSa8UhnGTA=Q@mail.gmail.com>
	<CAFEAcA_0wiAE8Ztjc5BaT6x+pobuFUwOx+b+s1X+kpdU=v+YPw@mail.gmail.com>
	<CAFEAcA_UucX-GF_tiOWdvX+mpqxm3YZTjgQuNFRLE0Vs3UWJ7g@mail.gmail.com>
	<20151119151627.GH2653@work-vm> <564EEA17.9080006@kamp.de>
	<CAFEAcA8bgOUF2LsnAk5hmV-vpFkongWCpD=7PDu7nhYNTLt9eA@mail.gmail.com>
In-Reply-To: <CAFEAcA8bgOUF2LsnAk5hmV-vpFkongWCpD=7PDu7nhYNTLt9eA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/14] Migration pull request
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Juan Quintela <quintela@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Amit Shah <amit.shah@redhat.com>, John Snow <jsnow@redhat.com>

Am 20.11.2015 um 12:33 schrieb Peter Maydell:
> On 20 November 2015 at 09:38, Peter Lieven <pl@kamp.de> wrote:
>> I wonder if there is a glitch in the PIO implementation of test-ide.c. As far as I understand the specs
>> it is not allowed to read data while the BSY flag is set. With the following change to the test-ide script
>> the test does not race:
>>
>> diff --git a/tests/ide-test.c b/tests/ide-test.c
>> index d1014bb..ab0489e 100644
>> --- a/tests/ide-test.c
>> +++ b/tests/ide-test.c
>> @@ -728,6 +728,7 @@ static void cdrom_pio_impl(int nblocks)
>>      for (i = 0; i < DIV_ROUND_UP(rxsize, limit); i++) {
>>          size_t offset = i * (limit / 2);
>>          size_t rem = (rxsize / 2) - offset;
>> +        ide_wait_clear(BSY);
>>          for (j = 0; j < MIN((limit / 2), rem); j++) {
>>              rx[offset + j] = le16_to_cpu(inw(IDE_BASE + reg_data));
>>          }
>>
>> Note: in the old sync version of the ATAPI PIO implementation this could not happen.
> This certainly fixes the stalls for me, though I don't know enough
> IDE to say whether it is the correct fix.
Thanks for testing.

I hope that John or Kevin can verify this fix?

Peter