From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for future work Date: Fri, 20 Nov 2015 17:01:18 +0100 Message-ID: <564F43CE.701@redhat.com> References: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, guangrong.xiao@linux.intel.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40774 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760560AbbKTQB1 (ORCPT ); Fri, 20 Nov 2015 11:01:27 -0500 In-Reply-To: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 20/11/2015 09:40, Takuya Yoshikawa wrote: > About patch 03: There was a comment on the usage of braces for a single line > else-if statement from Xiao. As I answered, checkpatch did not complain about > this, and when the corresponding if block has multiple lines, some developers > prefer/recommend this style. Feel free to modify it if you don't like it. I wonder if we can remove the "else if" completely. Will take a look after applying, early next week. > For these three, I'm not sure what we should do now, still RFC? > We can also consider other approaches, e.g. moving link_shadow_page() in the > kvm_get_mmu_page() as Paolo suggested before. I think I will include them in kvm/next. Thanks, Paolo