From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzoNk-0000js-RZ for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:17:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzoNj-0006UF-OR for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:17:52 -0500 References: <1448012159-24937-1-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <564F479A.9040700@redhat.com> Date: Fri, 20 Nov 2015 17:17:30 +0100 MIME-Version: 1.0 In-Reply-To: <1448012159-24937-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T7CwUd1kg6IIj1isavoa70xl3KpqGr7Rc" Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T7CwUd1kg6IIj1isavoa70xl3KpqGr7Rc Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 20.11.2015 10:35, Fam Zheng wrote: > Otherwise, a window flashes on my desktop (built with SDL). Other > iotest cases have that. >=20 > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/120 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 > index 9f13078..d899a3f 100755 > --- a/tests/qemu-iotests/120 > +++ b/tests/qemu-iotests/120 > @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} > {'execute': 'human-monitor-command', > 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\= "'}} > {'execute': 'quit'}" \ > - | $QEMU -qmp stdio -nodefaults \ > + | $QEMU -qmp stdio -nographic -nodefaults \ > -drive id=3Ddrv,if=3Dnone,file=3D"$TEST_IMG",driver=3Draw,= file.driver=3D$IMGFMT \ > | _filter_qmp | _filter_qemu_io > $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io >=20 This is the same patch as http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00623.html, but while both are correct, both need to fix 119, too, I think. (And while I would be fine with merging this and then taking a follow-up patch, I don't think we need to hurry for 2.5. Releases and iotests don't really care about each other, other than that we should pass all the iotests before a release unless we know what's wrong and don't care.)= Max --T7CwUd1kg6IIj1isavoa70xl3KpqGr7Rc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWT0eaAAoJEDuxQgLoOKytVbAIAKp+UMr8Aa6o29NhCUUZ3tJA OXhwn/9GnWS6XRyf75z+nDibDsrIuQxSmUFiddlE28tqlUzMtjqLLInz8qohgCMc mWhT1EWiTZwr/0Qo9EIn/RcwWr4hlLiPWehiKDT48P/fBCnVct3H4pNEu6EM7gC9 6ukT1pyaVSyrKO5X/xSaSZa4SbW/DG/Wli7GANoGNGZIcVqLY0a872AfMMWECCEP 5APZrhc7p8hv+VAHu7tuYMRgsxU4SOfpqLwGJN3ZMEzqPMoGYi4BjuEb+9aT5smI +BsbCm1kRCo9reYV5cQwbflajRaMeUc7EY8WDkhxes8KH3HXTnB7kMeckXh9Ekg= =P6km -----END PGP SIGNATURE----- --T7CwUd1kg6IIj1isavoa70xl3KpqGr7Rc--