From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH 1/2] doc: announce ABI change for cmdline
	buffer size
Date: Fri, 20 Nov 2015 17:28:43 +0100
Message-ID: <564F4A3B.5080204@6wind.com>
References: <1447087700-20921-1-git-send-email-nelio.laranjeiro@6wind.com>
 <B27915DBBA3421428155699D51E4CFE2023B7307@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
To: "Mcnamara, John" <john.mcnamara@intel.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 71298378E
 for <dev@dpdk.org>; Fri, 20 Nov 2015 17:28:50 +0100 (CET)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023B7307@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi N=E9lio,

On 11/10/2015 06:29 PM, Mcnamara, John wrote:
>=20
>=20
>> -----Original Message-----
>> From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
>> Sent: Monday, November 9, 2015 4:48 PM
>> To: dev@dpdk.org
>> Cc: olivier.matz@6wind.com; thomas.monjalon@6wind.com; Mcnamara, John;=
 Lu,
>> Wenzhuo
>> Subject: [PATCH 1/2] doc: announce ABI change for cmdline buffer size
>>
>> Current buffer size are not enough for a few testpmd commands.
>>
>> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>=20
> Acked-by: John McNamara <john.mcnamara@intel.com>
>=20

While I'm not fundamentally opposed to change the buffer size,
I'm wondering if the impacted commands shouldn't be reworked to
have smaller lines. 256 is already a quite big value for a line:

0123456789012345678901234567890123456789012345678901234567890123456789012=
3456789012345678901234567890123456789012345678901234567890123456789012345=
6789012345678901234567890123456789012345678901234567890123456789012345678=
9012345678901234567890123456789012345

For instance, we could change some commands to use contexts.
Dummy example with reta config:

testpmd> port config 0 rss reta
testpmd-reta-config-0> add hash1 queue1
testpmd-reta-config-0> add hash2 queue2
testpmd-reta-config-0> del hash1 queue1
testpmd-reta-config-0> show
testpmd-reta-config-0> commit
testpmd>

What do you think?

Regards,
Olivier