From: John Snow <jsnow@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test
Date: Fri, 20 Nov 2015 11:50:54 -0500 [thread overview]
Message-ID: <564F4F6E.2090801@redhat.com> (raw)
In-Reply-To: <CAFEAcA9QZ8x52jGsj8GwVRdO1+Pg6QqS2S0ZDZouzDmLuhtC_g@mail.gmail.com>
On 11/20/2015 09:37 AM, Peter Maydell wrote:
> On 20 November 2015 at 14:29, Peter Lieven <pl@kamp.de> wrote:
>> The check for the cleared BSY flag has to be performed
>> before each data transfer and not just before the
>> first one.
>>
>> Commit 5f81724d revealed this glitch as the BSY flag
>> was not set in ATAPI PIO transfers before.
>>
>> While at it fix the desciptions and add a comment before
>> the nested for loop that transfers the data.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>
> If the IDE folks can review this I'd like to apply it
> direct to master this afternoon so we can tag and roll rc1
> today.
>
> thanks
> -- PMM
>
Please do.
--js
next prev parent reply other threads:[~2015-11-20 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 14:29 [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test Peter Lieven
2015-11-20 14:37 ` Peter Maydell
2015-11-20 16:50 ` John Snow [this message]
2015-11-20 16:52 ` Kevin Wolf
2015-11-20 17:12 ` John Snow
2015-11-20 17:38 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F4F6E.2090801@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.