From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Bader Subject: Re: Fwd: Xen-4.1.6.1 backport for XSA156 Date: Fri, 20 Nov 2015 18:07:06 +0100 Message-ID: <564F533A.9050303@canonical.com> References: <564F0603.2080708@canonical.com> <564F363B.3010802@canonical.com> <564F518602000078000B7496@prv-mh.provo.novell.com> <564F45DE.1010504@canonical.com> <564F470B.2030908@canonical.com> <564F5E5502000078000B7548@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6715577351079707611==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zzp9Y-0003vF-JO for xen-devel@lists.xenproject.org; Fri, 20 Nov 2015 17:07:16 +0000 In-Reply-To: <564F5E5502000078000B7548@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6715577351079707611== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7rWpXgcLJkegvk7cA8d9RKXNvqnmS9Epq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7rWpXgcLJkegvk7cA8d9RKXNvqnmS9Epq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 20.11.2015 17:54, Jan Beulich wrote: >>>> On 20.11.15 at 17:15, wrote: >> So this is a quick hack I just tried and that keeps the HVM alive: >> >> @@ -1294,7 +1288,6 @@ void vmx_inject_hw_exception(int trap, i >> switch ( trap ) >> { >> case TRAP_debug: >> - type =3D X86_EVENTTYPE_SW_EXCEPTION; >> if ( guest_cpu_user_regs()->eflags & X86_EFLAGS_TF ) >> { >> __restore_debug_registers(curr); >> @@ -1302,6 +1295,13 @@ void vmx_inject_hw_exception(int trap, i >> } >> if ( cpu_has_monitor_trap_flag ) >> break; >> + if ( curr->domain->debugger_attached ) >> + { >> + /* Debug/Int3: Trap to debugger. */ >> + domain_pause_for_debugger(); >> + return; >> + } >> + break; >> case TRAP_int3: >> if ( curr->domain->debugger_attached ) >> { >> >> Though this looks like an ugly hack and probably is wrong in the other= case of >> TRAP_debug caused by an opcode... >=20 > Right, and I'm afraid this case doesn't get handled correctly even on > -unstable now. But apart from that aspect I think the change above > is okay. Oh, ok. Thanks for the review. I guess then I go with that. At least this= does no longer crash. -Stefan >=20 > Jan >=20 --7rWpXgcLJkegvk7cA8d9RKXNvqnmS9Epq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBCgAGBQJWT1NBAAoJEOhnXe7L7s6jQXMQALJ/7pyo1O1DS3airG9LHVTo ZpxSWZ8USXKFzlB8EXWnBmQxeelP9FvVv74YwZG5vNIRudlb9+DfIw6fJhYSMl9t /5XMwLN0RhkAX4lLrWBtDkw4OzBGRiMxrH3dq4WUlvkkNx2157TnUn/jTwoc64MQ CjFrA7GMAKT1M4T9du8Wa5tznk7jxkbquObjKvoNMKIeXheQy5VPJsKDAzgtmtey HVonCtVQHpVZJSIziEXI6DfeLqKMExMUJAGVdwrjvvYYhFMyYMOFD9LnvQM1r1aM 6YMiImncgq8cig/6BR4xUd7mM2jVQ5+gWv4ESgfq/Qehy5vd2iWPziiP6m5W2RZb YXhGQIBxQjpew5iNpWrOYKwJC2CGBAd2iKBBICbSJ8A0iAovtJA6aWNZwAv9tRWN GAgoO6P1uYccXjxllEcQRQuTvXL5x9AFpFRdKWsOfLRLvPBicn0v7Wu6BgFwyeTx JmvMaWQGmT5vnS5W6PXZzRmohHP+hbec40vKQh0EossJQYnAnMLXAWWLgUCvPHgF C6yT7Gs33l5HnvPunUKPI13JVS2TQ2jHw5bnKDrSQk0pSW35toe1svyLFXn+qf38 jHz+BxUc9EqrUSlvCUfYOPJ0eDKS4Um4Hofp8dt3MKuVQ4aRlHNzJat1Cb7SjhTE j7gqrH9onBGw6YGD+Jyz =QOk4 -----END PGP SIGNATURE----- --7rWpXgcLJkegvk7cA8d9RKXNvqnmS9Epq-- --===============6715577351079707611== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6715577351079707611==--