From: Greg Hackmann <ghackmann@google.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonathan Corbet <corbet@lwn.net>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2] pstore-ram: add Device Tree bindings
Date: Fri, 20 Nov 2015 10:32:08 -0800 [thread overview]
Message-ID: <564F6728.7050607@google.com> (raw)
In-Reply-To: <20151117211717.GA12750@rob-hp-laptop>
On 11/17/2015 01:17 PM, Rob Herring wrote:
>> +- record-size: maximum size in bytes of each dump done on oops/panic
>> + (defaults to 0)
>
> Perhaps the default should be something useful.
It's kind of a weird default, but I don't have any ideas for a better one.
First, the size you want is really determined by the number of dumps you
want to keep in your circular buffer. That's not something I want to
guess at.
Second, at least IME, a lot of devices legitimately want this set to 0.
They're pulling in ramoops for the persistent kernel and userspace logs.
>> +- unbuffered: if present, use uncached mappings to map the reserved region
>> + (defaults to cached mappings)
>
> It defaults to write-combined or buffered which is not really cached.
Will fix.
prev parent reply other threads:[~2015-11-20 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 0:13 [PATCH v2] pstore-ram: add Device Tree bindings Greg Hackmann
2015-11-17 17:48 ` Kees Cook
2015-11-17 21:17 ` Rob Herring
2015-11-20 18:32 ` Greg Hackmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F6728.7050607@google.com \
--to=ghackmann@google.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.