From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 20 Nov 2015 18:50:08 +0000 Subject: Re: [PATCH] ARM: shmobile: alt: Add pfc pins to DT Message-Id: <564F6B60.60405@cogentembedded.com> List-Id: References: <1447787440-11080-1-git-send-email-horms+renesas@verge.net.au> <564F0DE5.6040100@cogentembedded.com> <20151120183451.GD29534@verge.net.au> In-Reply-To: <20151120183451.GD29534@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 11/20/2015 09:34 PM, Simon Horman wrote: >>> PFC is already enabled on the r8a7794. >>> This adds pins for devices already enabled in DT on >>> the r8a7794 based alt board. >>> >>> Based on work by Mitsuhiro Kimura and Hisashi Nakamura. >>> >>> Cc: Mitsuhiro Kimura >>> Cc: Hisashi Nakamura >>> Signed-off-by: Simon Horman >>> >>> --- >>> Tested >>> --- >>> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts >>> index 928cfa641475..2e889991ce8f 100644 >>> --- a/arch/arm/boot/dts/r8a7794-alt.dts >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts >>> @@ -39,6 +39,23 @@ >>> clock-frequency = <20000000>; >>> }; >>> >>> +&pfc { >>> + scif2_pins: serial2 { >>> + renesas,groups = "scif2_data"; >>> + renesas,function = "scif2"; >>> + }; >>> + >>> + ether_pins: ether { >>> + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; >>> + renesas,function = "eth"; >>> + }; >>> + >>> + ether_b_pins: ether { >>> + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; >>> + renesas,function = "eth"; >>> + }; >>> +}; >>> + >>> &cmt0 { >>> status = "okay"; >>> }; >> >> Why add unreferenced pins? How have you tested this? > > Thanks for pointing out that oversight. I'll see about filling in the gaps. Sorry for noticing this too late, only when you were pushing your branches upstream... MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Fri, 20 Nov 2015 21:50:08 +0300 Subject: [PATCH] ARM: shmobile: alt: Add pfc pins to DT In-Reply-To: <20151120183451.GD29534@verge.net.au> References: <1447787440-11080-1-git-send-email-horms+renesas@verge.net.au> <564F0DE5.6040100@cogentembedded.com> <20151120183451.GD29534@verge.net.au> Message-ID: <564F6B60.60405@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/20/2015 09:34 PM, Simon Horman wrote: >>> PFC is already enabled on the r8a7794. >>> This adds pins for devices already enabled in DT on >>> the r8a7794 based alt board. >>> >>> Based on work by Mitsuhiro Kimura and Hisashi Nakamura. >>> >>> Cc: Mitsuhiro Kimura >>> Cc: Hisashi Nakamura >>> Signed-off-by: Simon Horman >>> >>> --- >>> Tested >>> --- >>> arch/arm/boot/dts/r8a7794-alt.dts | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts >>> index 928cfa641475..2e889991ce8f 100644 >>> --- a/arch/arm/boot/dts/r8a7794-alt.dts >>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts >>> @@ -39,6 +39,23 @@ >>> clock-frequency = <20000000>; >>> }; >>> >>> +&pfc { >>> + scif2_pins: serial2 { >>> + renesas,groups = "scif2_data"; >>> + renesas,function = "scif2"; >>> + }; >>> + >>> + ether_pins: ether { >>> + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; >>> + renesas,function = "eth"; >>> + }; >>> + >>> + ether_b_pins: ether { >>> + renesas,groups = "eth_link_b", "eth_mdio_b", "eth_rmii_b"; >>> + renesas,function = "eth"; >>> + }; >>> +}; >>> + >>> &cmt0 { >>> status = "okay"; >>> }; >> >> Why add unreferenced pins? How have you tested this? > > Thanks for pointing out that oversight. I'll see about filling in the gaps. Sorry for noticing this too late, only when you were pushing your branches upstream... MBR, Sergei