From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/4] qjson: do not save/restore contexts
Date: Fri, 20 Nov 2015 21:17:54 +0100 [thread overview]
Message-ID: <564F7FF2.9000509@redhat.com> (raw)
In-Reply-To: <564F6639.3080007@redhat.com>
On 20/11/2015 19:28, Eric Blake wrote:
>> > + token = parser_context_peek_token(ctxt);
>> > if (token == NULL) {
>> > goto out;
>> > }
>> >
>> > + if (token_get_type(token) != JSON_ESCAPE) {
>> > + goto out;
>> > + }
> Could merge these two conditionals.
Following the style of the rest of the file, for example:
if (token == NULL) {
goto out;
}
if (!token_is_operator(token, '{')) {
goto out;
}
Paolo
next prev parent reply other threads:[~2015-11-20 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 9:04 [Qemu-devel] [PATCH 0/4] qjson: save a lot of memory Paolo Bonzini
2015-11-20 9:04 ` [Qemu-devel] [PATCH 1/4] qjson: replace QString in JSONLexer with GString Paolo Bonzini
2015-11-20 18:23 ` Eric Blake
2015-11-20 20:16 ` Paolo Bonzini
2015-11-20 9:04 ` [Qemu-devel] [PATCH 2/4] qjson: do not save/restore contexts Paolo Bonzini
2015-11-20 18:28 ` Eric Blake
2015-11-20 20:17 ` Paolo Bonzini [this message]
2015-11-20 9:04 ` [Qemu-devel] [PATCH 3/4] qjson: store tokens in a GQueue Paolo Bonzini
2015-11-20 18:40 ` Eric Blake
2015-11-20 9:04 ` [Qemu-devel] [PATCH 4/4] qjson: surprise, allocating 6 QObjects per token is expensive Paolo Bonzini
2015-11-20 18:48 ` Eric Blake
2015-11-20 20:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F7FF2.9000509@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.