All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Brian Norris <computersforpeace@gmail.com>,
	Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] UBI: fix use of "VID" vs. "EC" in header self-check
Date: Fri, 20 Nov 2015 23:15:21 +0100	[thread overview]
Message-ID: <564F9B79.9070105@nod.at> (raw)
In-Reply-To: <1448057454-32664-1-git-send-email-computersforpeace@gmail.com>

Am 20.11.2015 um 23:10 schrieb Brian Norris:
> Looks like a typo, using UBI_EC_HDR_SIZE_CRC (note the "EC") to compute
> the CRC for the VID header.
> 
> This shouldn't cause any functional change, as both structures are 64
> bytes. Verified with:
> 
> 	BUILD_BUG_ON(UBI_VID_HDR_SIZE_CRC != UBI_EC_HDR_SIZE_CRC);
> 
> Reported here:
> http://lists.infradead.org/pipermail/linux-mtd/2013-September/048570.html
> 
> Reported by: Bill Pringlemeir <bpringlemeir@gmail.com>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> I was sorting through really old email. Don't ask.

Patch looks good, thanks for the exhumation! ;)

Thanks,
//richard

      reply	other threads:[~2015-11-20 22:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 22:10 [PATCH] UBI: fix use of "VID" vs. "EC" in header self-check Brian Norris
2015-11-20 22:15 ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564F9B79.9070105@nod.at \
    --to=richard@nod.at \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.