From: Guenter Roeck <linux@roeck-us.net>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>,
linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>,
Mike Looijmans <mike.looijmans@topic.nl>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH v2 4/6] watchdog: gpio_wdt: use core reboot notifier
Date: Fri, 20 Nov 2015 17:11:02 -0800 [thread overview]
Message-ID: <564FC4A6.3030305@roeck-us.net> (raw)
In-Reply-To: <1448056496-2335-5-git-send-email-damien.riegel@savoirfairelinux.com>
On 11/20/2015 01:54 PM, Damien Riegel wrote:
> Get rid of the custom reboot notifier block registration and use the one
> provided by the watchdog core.
>
> Note that this watchdog used to stop unconditionnaly on SYS_HALT and
> SYS_POWER_OFF. The core function now calls ops->stop on SYS_HALT and
> SYS_DOWN. To prevent the watchdog from being stopped on reboot, the
> "always-running" property must be set, otherwise it will now be stopped.
>
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> Reviewed-by: Vivien Didelot <vivien.didelot@savoirlinux.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2015-11-21 1:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 21:54 [PATCH v2 0/6] watchdog: factorize reboot notifier registration Damien Riegel
2015-11-20 21:54 ` [PATCH v2 1/6] watchdog: core: add reboot notifier support Damien Riegel
2015-11-21 1:10 ` Guenter Roeck
2015-11-23 15:02 ` In-reply-to: <1448056496-2335-1-git-send-email-damien.riegel@savoirfairelinux.com> Harald Geyer
2015-11-23 15:37 ` Damien Riegel
2015-11-23 18:20 ` Harald Geyer
2015-11-23 23:31 ` Damien Riegel
2015-11-25 17:04 ` Harald Geyer
2015-11-25 18:37 ` Guenter Roeck
2015-11-25 21:56 ` Harald Geyer
2015-11-25 22:10 ` Guenter Roeck
2015-11-23 15:57 ` Guenter Roeck
2015-11-20 21:54 ` [PATCH v2 2/6] watchdog: bcm47xx_wdt: use core reboot notifier Damien Riegel
2015-11-20 21:54 ` [PATCH v2 3/6] watchdog: cadence_wdt: " Damien Riegel
2015-11-20 21:54 ` [PATCH v2 4/6] watchdog: gpio_wdt: " Damien Riegel
2015-11-21 1:11 ` Guenter Roeck [this message]
2015-11-20 21:54 ` [PATCH v2 5/6] watchdog: softdog: " Damien Riegel
2015-11-20 21:54 ` [PATCH v2 6/6] watchdog: w83627hf_wdt: " Damien Riegel
2015-11-21 1:10 ` Guenter Roeck
2015-12-27 16:50 ` [PATCH v2 0/6] watchdog: factorize reboot notifier registration Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564FC4A6.3030305@roeck-us.net \
--to=linux@roeck-us.net \
--cc=damien.riegel@savoirfairelinux.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.