From: "René Scharfe" <l.s.r@web.de>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 4/2] test: use test_must_contain
Date: Sat, 21 Nov 2015 03:30:09 +0100 [thread overview]
Message-ID: <564FD731.6070804@web.de> (raw)
In-Reply-To: <1448068603-2112-1-git-send-email-szeder@ira.uka.de>
Am 21.11.2015 um 02:16 schrieb SZEDER Gábor:
> Hi,
>
>> diff --git a/t/t9810-git-p4-rcs.sh b/t/t9810-git-p4-rcs.sh
>> index 8134ab4..e02b490 100755
>> --- a/t/t9810-git-p4-rcs.sh
>> +++ b/t/t9810-git-p4-rcs.sh
>> @@ -294,8 +294,7 @@ test_expect_success 'cope with rcs keyword file deletion' '
>> echo "\$Revision\$" >kwdelfile.c &&
>> p4 add -t ktext kwdelfile.c &&
>> p4 submit -d "Add file to be deleted" &&
>> - cat kwdelfile.c &&
>> - grep 1 kwdelfile.c
>> + test_must_constain 1 kwdelfile.c
>
> s/constain/contain/
>
Thank you! I need to work on my vi fu.. Or install all optional tools
to be able to run the full test suite. ;)
René
prev parent reply other threads:[~2015-11-21 2:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 16:20 [PATCH 1/2] t1450: add tests for NUL in headers of commits and tags René Scharfe
2015-11-19 16:25 ` [PATCH 2/2] fsck: treat a NUL in a tag header as an error René Scharfe
2015-11-20 11:13 ` Jeff King
2015-11-20 20:18 ` Johannes Schindelin
2015-11-19 20:33 ` [PATCH 1/2] t1450: add tests for NUL in headers of commits and tags Eric Sunshine
2015-11-19 20:54 ` René Scharfe
2015-11-20 11:14 ` Jeff King
2015-11-20 20:49 ` René Scharfe
2015-11-20 20:50 ` [PATCH 3/2] test: factor out helper function test_must_contain René Scharfe
2015-11-21 8:11 ` Johannes Sixt
2015-11-21 9:35 ` René Scharfe
2015-11-20 20:50 ` [PATCH 4/2] test: use test_must_contain René Scharfe
2015-11-21 1:16 ` SZEDER Gábor
2015-11-21 2:30 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564FD731.6070804@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.