From: "Torsten Bögershausen" <tboegi@web.de>
To: Stefan Beller <sbeller@google.com>, peff@peff.net, git@vger.kernel.org
Cc: jrnieder@gmail.com, johannes.schindelin@gmail.com, j6t@kdbg.org,
tboegi@web.de
Subject: Re: [PATCHv2] run-command: detect finished children by closed pipe rather than waitpid
Date: Sat, 21 Nov 2015 07:58:38 +0100 [thread overview]
Message-ID: <5650161E.9060305@web.de> (raw)
In-Reply-To: <1448053719-28340-1-git-send-email-sbeller@google.com>
On 2015-11-20 22.08, Stefan Beller wrote:
The patch looks good at first glance, one minor remark below:
>
> diff --git a/run-command.c b/run-command.c
> @@ -1071,70 +1089,31 @@ static void pp_output(struct parallel_processes *pp)
>
> static int pp_collect_finished(struct parallel_processes *pp)
> {
> - int i = 0;
> - pid_t pid;
> - int wait_status, code;
> + int i, code;
code is probably "return code"?
woud "ret_value", "res" or "rc" make that more clear ?
next prev parent reply other threads:[~2015-11-21 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 21:08 [PATCHv2] run-command: detect finished children by closed pipe rather than waitpid Stefan Beller
2015-11-20 22:05 ` Jonathan Nieder
2015-11-20 23:24 ` Johannes Sixt
2015-11-21 6:58 ` Torsten Bögershausen [this message]
2015-11-23 18:44 ` Stefan Beller
2015-11-23 19:01 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5650161E.9060305@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.