All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
	Cristina Opriceana <cristina.opriceana@gmail.com>
Cc: linux-iio@vger.kernel.org, daniel.baluta@intel.com,
	octavian.purdila@intel.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: Move IIO Dummy Driver out of staging
Date: Sat, 21 Nov 2015 18:23:14 +0000	[thread overview]
Message-ID: <5650B692.3000706@kernel.org> (raw)
In-Reply-To: <5650B4C5.2050803@metafoo.de>

On 21/11/15 18:15, Lars-Peter Clausen wrote:
> On 10/09/2015 03:31 PM, Cristina Opriceana wrote:
>> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>> index 6d5b38d..85de198 100644
>> --- a/drivers/staging/iio/Kconfig
>> +++ b/drivers/staging/iio/Kconfig
>> @@ -17,32 +17,32 @@ source "drivers/staging/iio/meter/Kconfig"
>>  source "drivers/staging/iio/resolver/Kconfig"
>>  source "drivers/staging/iio/trigger/Kconfig"
>>  
>> -config IIO_DUMMY_EVGEN
>> -       tristate
>> -
>> -config IIO_SIMPLE_DUMMY
>> -       tristate "An example driver with no hardware requirements"
>> -       help
>> -	 Driver intended mainly as documentation for how to write
>> -	 a driver. May also be useful for testing userspace code
>> -	 without hardware.
>> -
>> -if IIO_SIMPLE_DUMMY
>> -
>> -config IIO_SIMPLE_DUMMY_EVENTS
>> -       bool "Event generation support"
>> -       select IIO_DUMMY_EVGEN
>> -       help
>> -         Add some dummy events to the simple dummy driver.
>> -
>> -config IIO_SIMPLE_DUMMY_BUFFER
>> -	bool "Buffered capture support"
>> -	select IIO_BUFFER
>> -	select IIO_TRIGGER
>> -	select IIO_KFIFO_BUF
>> -	help
>> -	  Add buffered data capture to the simple dummy driver.
>> -
>> -endif # IIO_SIMPLE_DUMMY
>> +#config IIO_DUMMY_EVGEN
>> +#       tristate
>> +#
>> +#config IIO_SIMPLE_DUMMY
>> +#       tristate "An example driver with no hardware requirements"
>> +#       help
>> +#	 Driver intended mainly as documentation for how to write
>> +#	 a driver. May also be useful for testing userspace code
>> +#	 without hardware.
>> +
>> +#if IIO_SIMPLE_DUMMY
>> +
>> +#config IIO_SIMPLE_DUMMY_EVENTS
>> +#       bool "Event generation support"
>> +#       select IIO_DUMMY_EVGEN
>> +#      help
>> +#        Add some dummy events to the simple dummy driver.
>> +
>> +#config IIO_SIMPLE_DUMMY_BUFFER
>> +#	bool "Buffered capture support"
>> +#	select IIO_BUFFER
>> +# select IIO_TRIGGER
>> +#	select IIO_KFIFO_BUF
>> +#	help
>> +#	  Add buffered data capture to the simple dummy driver.
> 
> Any particular reason why those where commented out rather than removed?
> 
Gah I'd missed that entirely and they have now been in my tree sometime so
I will have to do it as an additional patch. Good point Lars.

Patch shortly... 

J

      reply	other threads:[~2015-11-21 18:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 13:31 [PATCH] iio: Move IIO Dummy Driver out of staging Cristina Opriceana
2015-10-11 13:28 ` Jonathan Cameron
2015-10-12 17:59   ` Daniel Baluta
2015-10-13  5:44     ` Jonathan Cameron
2015-10-13 10:56       ` Lars-Peter Clausen
2015-10-25 12:33 ` Jonathan Cameron
2015-11-21 18:15 ` Lars-Peter Clausen
2015-11-21 18:23   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5650B692.3000706@kernel.org \
    --to=jic23@kernel.org \
    --cc=cristina.opriceana@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.