From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Bader Subject: Re: Fwd: Xen-4.1.6.1 backport for XSA156 Date: Mon, 23 Nov 2015 09:45:23 +0100 Message-ID: <5652D223.5090605@canonical.com> References: <564F0603.2080708@canonical.com> <564F363B.3010802@canonical.com> <564F518602000078000B7496@prv-mh.provo.novell.com> <564F45DE.1010504@canonical.com> <564F470B.2030908@canonical.com> <564F5E5502000078000B7548@prv-mh.provo.novell.com> <564F533A.9050303@canonical.com> <5652D04702000078000B7AA8@prv-mh.provo.novell.com> <5652D39C02000078000B7AB3@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1089474318573003448==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a0mki-0001KN-Sp for xen-devel@lists.xenproject.org; Mon, 23 Nov 2015 08:45:37 +0000 In-Reply-To: <5652D39C02000078000B7AB3@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1089474318573003448== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5bMVTobHMJAUl75sRFOhwcMXx3hxJRVIp" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5bMVTobHMJAUl75sRFOhwcMXx3hxJRVIp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23.11.2015 08:51, Jan Beulich wrote: >>>> On 23.11.15 at 08:37, wrote: >> Actually there's no problem with ICEBP - just like INTnn it isn't itse= lf >> interceptable (and the injection of vector 0x01 from the x86 >> emulator path can't fully distinguish between ICEBP and INT $1 in >> these old versions anyway). So what you have should be good >> enough, albeit I think I'll code it slightly differently (keeping the = fall- >> through in place). >=20 > Like this: >=20 > @@ -1364,7 +1358,6 @@ void vmx_inject_hw_exception(int trap, i > switch ( trap ) > { > case TRAP_debug: > - type =3D X86_EVENTTYPE_SW_EXCEPTION; > if ( guest_cpu_user_regs()->eflags & X86_EFLAGS_TF ) > { > __restore_debug_registers(curr); > @@ -1379,9 +1372,11 @@ void vmx_inject_hw_exception(int trap, i > domain_pause_for_debugger(); > return; > } > - > - type =3D X86_EVENTTYPE_SW_EXCEPTION; > - __vmwrite(VM_ENTRY_INSTRUCTION_LEN, 1); /* int3 */ > + if ( trap =3D=3D TRAP_int3 ) > + { > + type =3D X86_EVENTTYPE_SW_EXCEPTION; > + __vmwrite(VM_ENTRY_INSTRUCTION_LEN, 1); > + } > } > =20 > if ( unlikely(intr_info & INTR_INFO_VALID_MASK) && >=20 Yeah, for my side I think I stick with what I had because I already have = now run that variant through testing. But I will include both variants when talki= ng to the Debian guys. -Stefan > Jan >=20 --5bMVTobHMJAUl75sRFOhwcMXx3hxJRVIp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBCgAGBQJWUtIrAAoJEOhnXe7L7s6j55kP/iihho7gkhLdK5eQMqAX9sw/ wr88PPoEQCzTbwjdoti6yRgdH/KwK+EV8JF5ypfIAzATkt9w7rr3H+pBrSt4Gt/x JAwb5U631Ru+r9BvNi2BL/o8uecSC/hRH3L5H3A4eDY3vqHnUH996OxP3oE4Hdbm cwOIQAo0zuWewRyfbxP880Ab9dQ/M/0+5UU5cGM76u6SwwCM628xirh8mO8u/1R2 WN13MaUo8YDcRxBCbqWpIwlHXBoycTMTLL1CLuEY+f+EnRZlW1/pUkQsdTh/3V4W Ah167+ECMKCEHWq6oJJRdcBJcBvdKrJepSqjlOWlNO6xFfSHEvtDHFwVLEXNo5JO t+RXbpiP2SDpVoLQ/ThkLh8fk4tQXqVvBf36qwDpzq+Tkccw7wXz0ddXHIp0bJNu n7ZM9aYT2LbblNMdwn3V+tNyzLAe8HHFL4+D3OaB1Y3226b0BGnZKNTVydFnpYRB eDTNedQ6Z63f36EhiCtIgMxUDY5faxU3ezb/hH1KdPFZ/+dOMF7iMB806bB+VBVb kyRwaLJnVznUAMKwDVhlW2H6EuFXSV/IL5Pv4mldFQrED2tHzHcNQAfO48rdour4 GerjO9IpEZzswTzzcDKXBMPUC0KDvJcjJR7oiaOlwSkTB2+TAeYIshlI2xcgiz/+ sXKSAg5hmCFGOPX4UCyo =UA/L -----END PGP SIGNATURE----- --5bMVTobHMJAUl75sRFOhwcMXx3hxJRVIp-- --===============1089474318573003448== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1089474318573003448==--