From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Cc: dan.carpenter@oracle.com
Subject: Re: [PATCH 1/2] can: fix assignment of error location in CAN error messages
Date: Mon, 23 Nov 2015 09:47:32 +0100 [thread overview]
Message-ID: <5652D2A4.6070508@pengutronix.de> (raw)
In-Reply-To: <1448127681-8533-1-git-send-email-socketcan@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On 11/21/2015 06:41 PM, Oliver Hartkopp wrote:
> As Dan Carpenter reported in http://marc.info/?l=linux-can&m=144793696016187
> the assignment of the error location in CAN error messages had some bit wise
> overlaps. Indeed the value to be assigned in data[3] is no bitfield but defines
> a single value which points to a location inside the CAN frame on the wire.
>
> This patch fixes the assignments for the error locations in error messages.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Applied both to the can tree.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2015-11-23 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 17:41 [PATCH 1/2] can: fix assignment of error location in CAN error messages Oliver Hartkopp
2015-11-21 17:41 ` [PATCH 2/2] [RFC] can: remove obsolete assignment for CAN protocol error type Oliver Hartkopp
2015-11-23 8:47 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652D2A4.6070508@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dan.carpenter@oracle.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.