From: Michael Wang <yun.wang@profitbricks.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: nfnetlink warnings
Date: Mon, 23 Nov 2015 11:20:18 +0100 [thread overview]
Message-ID: <5652E862.7000605@profitbricks.com> (raw)
In-Reply-To: <20151123095455.GB5134@pd.tnic>
On 11/23/2015 10:54 AM, Borislav Petkov wrote:
> Hi Michael,
>
> On Mon, Nov 23, 2015 at 10:49:34AM +0100, Michael Wang wrote:
>> Why not just initialized it as NULL, or mark it as uninitialized_var()?
>
> because I'd like us to save us the redundant NULL initialization in the
> if-case.
Well, I would vote initialized with NULL, rather than use another else
branch to do the same thing.
>
> I'm not saying any of the approaches are good visually, though. Who
> knows, someone might have a better idea like, maybe "Oh, I wanted to
> rewrite that code and this handlong is going to be different anyway ..."
> or so. Or something to that effect.
Who want to do that would take responsibility to make an else branch at
that time, but reserve the branch at this moment sounds unnecessary, and
not that pretty frankly speaking.
>
> Btw, please do not top-post.
Enjoy ;-)
Regards,
Michael Wang
>
> Thanks.
>
next prev parent reply other threads:[~2015-11-23 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 9:36 nfnetlink warnings Borislav Petkov
2015-11-23 9:36 ` Borislav Petkov
2015-11-23 9:49 ` Michael Wang
2015-11-23 9:54 ` Borislav Petkov
2015-11-23 10:20 ` Michael Wang [this message]
2015-11-23 10:30 ` Pablo Neira Ayuso
2015-11-23 10:32 ` Borislav Petkov
2015-11-23 10:36 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652E862.7000605@profitbricks.com \
--to=yun.wang@profitbricks.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.