From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Cong Wang <cwang@twopensource.com>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next v2 2/9] net: ipmr: always define mroute_reg_vif_num
Date: Mon, 23 Nov 2015 11:39:19 +0100 [thread overview]
Message-ID: <5652ECD7.1000104@cumulusnetworks.com> (raw)
In-Reply-To: <CAHA+R7Pra5DW8UNyPDQKK6Y=J8nz4LvNvmHcsP7pY+-U5NHCKg@mail.gmail.com>
On 11/23/2015 06:23 AM, Cong Wang wrote:
> On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov
> <razor@blackwall.org> wrote:
>> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>>
>> Before mroute_reg_vif_num was defined only if any of the CONFIG_PIMSM_
>> options were set, but that's not really necessary as the size of the
>> struct is the same in both cases (checked with pahole, both cases size
>> is 3256 bytes) and we can remove some unnecessary ifdefs to simplify the
>> code.
>>
>
> Not sure if this really simplifies the code, since now
> mroute_reg_vif_num is hidden
> deeper after your patch and there are still some code under CONFIG_IP_PIMSM.
>
CONFIG_IP_PIMSM is removed in the next patch, and it's not "hidden" anymore
than it was before.
> If you really care about it, how about introducing a helper function
> to set and get
> mrt->mroute_reg_vif_num?
>
Patches are welcome, if you don't get to it then I will with the next
set.
next prev parent reply other threads:[~2015-11-23 10:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 14:57 [PATCH net-next v2 0/9] net: ipmr: cleanups and minor improvements Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 1/9] net: ipmr: move the tbl id check in ipmr_new_table Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 2/9] net: ipmr: always define mroute_reg_vif_num Nikolay Aleksandrov
2015-11-23 5:23 ` Cong Wang
2015-11-23 10:39 ` Nikolay Aleksandrov [this message]
2015-11-21 14:57 ` [PATCH net-next v2 3/9] net: ipmr: remove some pimsm ifdefs and simplify Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 4/9] net: ipmr: fix code and comment style Nikolay Aleksandrov
2015-11-23 5:30 ` Cong Wang
2015-11-23 10:40 ` Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 5/9] net: ipmr: make ip_mroute_getsockopt more understandable Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 6/9] net: ipmr: drop an instance of CONFIG_IP_MROUTE_MULTIPLE_TABLES Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 7/9] net: ipmr: drop ip_mr_init() mrt_cachep null check as we'll panic if it fails Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt Nikolay Aleksandrov
2015-11-23 5:44 ` Cong Wang
2015-11-23 10:49 ` Nikolay Aleksandrov
2015-11-21 14:57 ` [PATCH net-next v2 9/9] net: ipmr: factor out common vif init code Nikolay Aleksandrov
2015-11-23 20:07 ` [PATCH net-next v2 0/9] net: ipmr: cleanups and minor improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652ECD7.1000104@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.