From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: atmel: Properly fix clock configuration
Date: Mon, 23 Nov 2015 15:35:50 +0100 [thread overview]
Message-ID: <56532446.7080206@googlemail.com> (raw)
In-Reply-To: <1446753510-16783-1-git-send-email-gregory.clement@free-electrons.com>
Hi Gregory,
On 05.11.15 20:58, Gregory CLEMENT wrote:
> Timing issue occurs on eMMC not only when modifying the frequency but
> also for all the switch command(CMD6). According to the MMC spec waiting
> 8 clocks after a switch command would be the thing to do.
>
> This patch allows fixing CPU hang observed when trying to changing the
> bus width on a eMMC on SAMA5D4.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Tested-by: Marek Vasut <marex@denx.de> # on DENX MA5D4EV
this patch seams to break avr32 ... I'm on it to investigate the root cause.
Andreas
> ---
> drivers/mmc/gen_atmel_mci.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/gen_atmel_mci.c b/drivers/mmc/gen_atmel_mci.c
> index da870c6..f090b27 100644
> --- a/drivers/mmc/gen_atmel_mci.c
> +++ b/drivers/mmc/gen_atmel_mci.c
> @@ -36,6 +36,7 @@ struct atmel_mci_priv {
> struct mmc_config cfg;
> struct atmel_mci *mci;
> unsigned int initialized:1;
> + unsigned int curr_clk;
> };
>
> /* Read Atmel MCI IP version */
> @@ -91,7 +92,10 @@ static void mci_set_mode(struct mmc *mmc, u32 hz, u32 blklen)
>
> }
> }
> -
> + if (version >= 0x500)
> + priv->curr_clk = bus_hz / (clkdiv * 2 + clkodd + 2);
> + else
> + priv->curr_clk = (bus_hz / (clkdiv + 1)) / 2;
> blklen &= 0xfffc;
>
> mr = MMCI_BF(CLKDIV, clkdiv);
> @@ -118,8 +122,6 @@ static void mci_set_mode(struct mmc *mmc, u32 hz, u32 blklen)
> if (mmc->card_caps & mmc->cfg->host_caps & MMC_MODE_HS)
> writel(MMCI_BIT(HSMODE), &mci->cfg);
>
> - udelay(50);
> -
> priv->initialized = 1;
> }
>
> @@ -323,6 +325,13 @@ mci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
> }
> }
>
> + /*
> + * After the switch command, wait for 8 clocks before the next
> + * command
> + */
> + if (cmd->cmdidx == MMC_CMD_SWITCH)
> + udelay(8*1000000/ priv->curr_clk); /* 8 clk in us */
> +
> return 0;
> }
>
>
next prev parent reply other threads:[~2015-11-23 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 19:58 [U-Boot] [PATCH v2] mmc: atmel: Properly fix clock configuration Gregory CLEMENT
2015-11-05 20:15 ` Marek Vasut
2015-11-06 9:28 ` Gregory CLEMENT
2015-11-06 13:39 ` Marek Vasut
2015-11-23 14:35 ` Andreas Bießmann [this message]
2015-11-23 14:49 ` Andreas Bießmann
2015-12-01 16:52 ` Andreas Bießmann
2016-01-27 12:59 ` [U-Boot] [U-Boot, " Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56532446.7080206@googlemail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.