From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0sO3-000812-4E for qemu-devel@nongnu.org; Mon, 23 Nov 2015 09:46:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0sNz-0001ng-SE for qemu-devel@nongnu.org; Mon, 23 Nov 2015 09:46:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0sNz-0001nW-Mx for qemu-devel@nongnu.org; Mon, 23 Nov 2015 09:46:31 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 64308A3B73 for ; Mon, 23 Nov 2015 14:46:31 +0000 (UTC) References: <1448282346-11626-1-git-send-email-kwolf@redhat.com> <1448282346-11626-3-git-send-email-kwolf@redhat.com> From: Paolo Bonzini Message-ID: <565326BE.3050007@redhat.com> Date: Mon, 23 Nov 2015 15:46:22 +0100 MIME-Version: 1.0 In-Reply-To: <1448282346-11626-3-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] test-aio: Fix event notifier cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: famz@redhat.com, stefanha@redhat.com On 23/11/2015 13:39, Kevin Wolf wrote: > One test case closed an event notifier (event_notifier_cleanup()) > without first disabling it (set_event_notifier(..., NULL)). This > resulted in a leftover handle 0 that was added to each subsequent > WaitForMultipleObjects() call, causing the function to fail (invalid > handle). > > Signed-off-by: Kevin Wolf > --- > tests/test-aio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/test-aio.c b/tests/test-aio.c > index 1623803..e188d8c 100644 > --- a/tests/test-aio.c > +++ b/tests/test-aio.c > @@ -393,6 +393,7 @@ static void test_aio_external_client(void) > aio_enable_external(ctx); > } > assert(aio_poll(ctx, false)); > + set_event_notifier(ctx, &data.e, NULL); > event_notifier_cleanup(&data.e); > } > } > Reviewed-by: Paolo Bonzini