From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0thF-00076U-RV for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:10:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0thC-0003mT-Iz for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:10:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0thC-0003mN-EA for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:10:26 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 0A1A4C077551 for ; Mon, 23 Nov 2015 16:10:26 +0000 (UTC) References: <1448273262-13845-1-git-send-email-peterx@redhat.com> <1448273262-13845-2-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <56533A71.7000607@redhat.com> Date: Mon, 23 Nov 2015 09:10:25 -0700 MIME-Version: 1.0 In-Reply-To: <1448273262-13845-2-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DaB2qGC2nQLup7DCseN5WqMLpRhBXANSa" Subject: Re: [Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DaB2qGC2nQLup7DCseN5WqMLpRhBXANSa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/23/2015 03:07 AM, Peter Xu wrote: > This patch only add the interfaces, but not implementing them. >=20 > Signed-off-by: Peter Xu > --- > dump.c | 3 ++- > hmp-commands.hx | 5 +++-- > hmp.c | 3 ++- > qapi-schema.json | 3 ++- > qmp-commands.hx | 4 ++-- > 5 files changed, 11 insertions(+), 7 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -2132,7 +2132,8 @@ > ## > { 'command': 'dump-guest-memory', > 'data': { 'paging': 'bool', 'protocol': 'str', '*begin': 'int', > - '*length': 'int', '*format': 'DumpGuestMemoryFormat' } } > + '*length': 'int', '*format': 'DumpGuestMemoryFormat', > + 'detach': 'bool'} } Missing documentation of the new flag, of its default state, and with a mention that it is '(since 2.6)'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DaB2qGC2nQLup7DCseN5WqMLpRhBXANSa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWUzpxAAoJEKeha0olJ0NqYXMIAIoSdWCVOu2Qdfs8xTUnR/q9 WUaUwEqCDelQ21zsbZ9A0uhMMbt5HiNUdzO6iQBzHdpjIykA6r3fbsNNx8Soph0h Sa0vklQBo5zBmlOO2/NcIkgtlGzG1iWTWsSk1WHfSPyjySoSvq0IPJ9z8xYqbIkc ajBku5eV85tjdrhkWdV8t/KsRysTaWkwpxoqq/YE65a0r8zcut+S3MtMkh2AMy4g /86ESocUL3UIc9gWnC/3ChxMrO1iVHhq/nDlrIlY7KuadPKrzsbQJpLqhENLjrvM qfD4t9H7pT7kLwKoIlblnD+NkrHYacquAsEK2VHPVC/ICb7fVHYDdHRWXDUUCmk= =2Mv1 -----END PGP SIGNATURE----- --DaB2qGC2nQLup7DCseN5WqMLpRhBXANSa--