All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Denis Turischev <denis.turischev@compulab.co.il>,
	Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sp5100_tco: Add AMD Mullins platform support
Date: Mon, 23 Nov 2015 08:53:48 -0800	[thread overview]
Message-ID: <5653449C.5060909@roeck-us.net> (raw)
In-Reply-To: <5652C765.8030302@compulab.co.il>

On 11/22/2015 11:59 PM, Denis Turischev wrote:
> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> reuse the existent sp5100_tco driver.
>
> v2: rebased to v4.4-rc2
>
> Signed-off-by: Denis Turischev <denis.turischev@compulab.co.il>
>
> diff -Nru linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c linux-4.4-rc2/drivers/watchdog/sp5100_tco.c
> --- linux-4.4-rc2.orig/drivers/watchdog/sp5100_tco.c	2015-11-23 02:45:59.000000000 +0200
> +++ linux-4.4-rc2/drivers/watchdog/sp5100_tco.c	2015-11-23 09:51:48.701245853 +0200
> @@ -306,6 +306,8 @@
>   static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>   	{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
>   	  PCI_ANY_ID, },
> +	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
> +	  PCI_ANY_ID, },
>   	{ 0, },			/* End of list */
>   };
>   MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);

$ scripts/checkpatch.pl index.html
ERROR: trailing whitespace
#32: FILE: drivers/watchdog/sp5100_tco.c:310:
+^I  PCI_ANY_ID, }, $

total: 1 errors, 0 warnings, 8 lines checked

Please fix.

Guenter


  reply	other threads:[~2015-11-23 16:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19  9:56 [PATCH] sp5100_tco: Add AMD Mullins platform support Denis Turischev
2015-11-19 16:13 ` Guenter Roeck
2015-11-20  2:33 ` Huang Rui
2015-11-22  8:54   ` Denis Turischev
2015-11-23  3:35     ` Huang Rui
2015-11-23  7:59 ` [PATCH v2] " Denis Turischev
2015-11-23 16:53   ` Guenter Roeck [this message]
2015-11-24  8:46     ` [PATCH v3] " Denis Turischev
2015-11-24 13:52       ` Guenter Roeck
2015-12-27 19:44       ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5653449C.5060909@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=denis.turischev@compulab.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.