From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0uc2-0006mX-8d for qemu-devel@nongnu.org; Mon, 23 Nov 2015 12:09:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0uc1-0008IZ-6J for qemu-devel@nongnu.org; Mon, 23 Nov 2015 12:09:10 -0500 References: <1448012159-24937-1-git-send-email-famz@redhat.com> <564F479A.9040700@redhat.com> <56527A0F.2030703@linux.vnet.ibm.com> <20151123023301.GA29069@ad.usersys.redhat.com> <5652840E.1000400@linux.vnet.ibm.com> From: Max Reitz Message-ID: <5653482B.3020603@redhat.com> Date: Mon, 23 Nov 2015 18:08:59 +0100 MIME-Version: 1.0 In-Reply-To: <5652840E.1000400@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ALq1Kdum5Wi6dvQLb1lmQeF6eSDrtJPFW" Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 120 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tu bo , Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ALq1Kdum5Wi6dvQLb1lmQeF6eSDrtJPFW Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 23.11.2015 04:12, tu bo wrote: > Hi Fam, Max: >=20 > On 11/23/2015 10:33 AM, Fam Zheng wrote: >> On Mon, 11/23 10:29, tu bo wrote: >>> Hi Max: >>> >>> On 11/21/2015 12:17 AM, Max Reitz wrote: >>>> On 20.11.2015 10:35, Fam Zheng wrote: >>>>> Otherwise, a window flashes on my desktop (built with SDL). Other >>>>> iotest cases have that. >>>>> >>>>> Signed-off-by: Fam Zheng >>>>> --- >>>>> tests/qemu-iotests/120 | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120 >>>>> index 9f13078..d899a3f 100755 >>>>> --- a/tests/qemu-iotests/120 >>>>> +++ b/tests/qemu-iotests/120 >>>>> @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'} >>>>> {'execute': 'human-monitor-command', >>>>> 'arguments': {'command-line': 'qemu-io drv \"write -P 42 0= >>>>> 64k\"'}} >>>>> {'execute': 'quit'}" \ >>>>> - | $QEMU -qmp stdio -nodefaults \ >>>>> + | $QEMU -qmp stdio -nographic -nodefaults \ >>>>> -drive >>>>> id=3Ddrv,if=3Dnone,file=3D"$TEST_IMG",driver=3Draw,file.driver=3D$I= MGFMT \ >>>>> | _filter_qmp | _filter_qemu_io >>>>> $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io >>>>> >>>> >>>> This is the same patch as >>>> http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00623.htm= l, >>>> but while both are correct, both need to fix 119, too, I think. >>>> >>>> (And while I would be fine with merging this and then taking a >>>> follow-up >>>> patch, I don't think we need to hurry for 2.5. Releases and iotests >>>> don't really care about each other, other than that we should pass a= ll >>>> the iotests before a release unless we know what's wrong and don't >>>> care.) >>>> >>> >>> thanks for your advice. I plan to fix 119 in a follow-up patch. >>> currently, 119 is notrun for s390x, and I hope to spend some time to >>> investigate it later. >>> >> >> I'm sending a new version fixing both scripts. >=20 > Good news. >=20 > Hi Max: >=20 > If it's fine to you, I'll remove patch for 120 from my patch set. thank= s Yep, that's completely fine, of course. Max --ALq1Kdum5Wi6dvQLb1lmQeF6eSDrtJPFW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWU0grAAoJEDuxQgLoOKyt85AH/35R8Ono+VDqDNiHlbBegUhj RheFyPfX4T5Eu4tKUx2xp+fG4QnIs8wt8QxERyEQOHxnfilLNq/Svy5ahIxbP/UU unyaL308p92EaQO6s3JQN56pYzJE2TujLmy3EXdStCULdg7CCGkBV7ZJaakKzHPI Uie2R17JoZSdPM+xfICQPXoN0NmC6PzIn07pNnm4hVGVYz1QaWpaM8KsZkL18ReV QoiNpE7NSu4I9AEElOaWB6FexLWkW9eN8I3bJHyfY/X+EiSUdBGzG3WLVmLxDzIa vRHqyFgoKxGrSY0PssWK9ckzmJ6B1nIm1WhCRfJ9SNvoB1YVepRcRFR/cuOWz9Q= =rN4n -----END PGP SIGNATURE----- --ALq1Kdum5Wi6dvQLb1lmQeF6eSDrtJPFW--