From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0vYz-0002Sa-BG for qemu-devel@nongnu.org; Mon, 23 Nov 2015 13:10:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0vYv-0007o6-2x for qemu-devel@nongnu.org; Mon, 23 Nov 2015 13:10:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0vYu-0007o0-Tq for qemu-devel@nongnu.org; Mon, 23 Nov 2015 13:10:01 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 71E36C0A525E for ; Mon, 23 Nov 2015 18:10:00 +0000 (UTC) References: <1448300659-23559-1-git-send-email-pbonzini@redhat.com> <1448300659-23559-3-git-send-email-pbonzini@redhat.com> <565353ED.1090502@redhat.com> From: Paolo Bonzini Message-ID: <56535674.2050807@redhat.com> Date: Mon, 23 Nov 2015 19:09:56 +0100 MIME-Version: 1.0 In-Reply-To: <565353ED.1090502@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org Cc: armbru@redhat.com On 23/11/2015 18:59, Laszlo Ersek wrote: >> > The only interesting thing is that parse_keyword always eats >> > a TOKEN_KEYWORD, even if it is invalid, so it must come last in >> > parse_value (otherwise, NULL is returned, parse_literal is invoked >> > and it tries to peek beyond end of input). This is caught by >> > /errors/unterminated/literal, which actually checks for an untermina= ted >> > keyword. =E0=B2=A0_=E0=B2=A0 > Is it accepted practice to put UTF-8 in commit messages? (Or, actually, > anywhere in patches, except maybe the notes section?) >=20 > I'd recommend o_O. Perhaps not Kannada, but Unicode 0xA1 to 0x1FF is pretty common in commit messages. Paolo