From: Ian Abbott <abbotti@mev.co.uk>
To: Jitendra Kumar Khasdev <jkhasdev@gmail.com>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org
Cc: jitendra.khasdev@hotwaxsystems.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments
Date: Mon, 23 Nov 2015 18:41:25 +0000 [thread overview]
Message-ID: <56535DD5.9060208@mev.co.uk> (raw)
In-Reply-To: <1448300721-3385-1-git-send-email-jitendra.khasdev@hotwaxsystems.com>
On 23/11/15 17:45, Jitendra Kumar Khasdev wrote:
> This patch is to comedilib.h file that fixes up following warnings
> reported by checkpatch.pl :
> I) Block comments use * on subsequent lines
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
> index 56baf85..e530028 100644
> --- a/drivers/staging/comedi/comedilib.h
> +++ b/drivers/staging/comedi/comedilib.h
> @@ -1,20 +1,20 @@
> /*
> - linux/include/comedilib.h
> - header file for kcomedilib
> -
> - COMEDI - Linux Control and Measurement Device Interface
> - Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org>
> -
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> -
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> -*/
> + * linux/include/comedilib.h
> + *
> + * COMEDI - Linux Control and Measurement Device Interface
> + * Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
>
> #ifndef _LINUX_COMEDILIB_H
> #define _LINUX_COMEDILIB_H
>
You removed the "header file for kcomedilib" line, which was probably
more useful than the "linux/include/comedilib.h" line, especially as the
pathname "linux/include/comedilib.h" isn't very accurate!
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-11-23 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 17:45 [PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments Jitendra Kumar Khasdev
2015-11-23 18:41 ` Ian Abbott [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-24 3:12 Jitendra Kumar Khasdev
2015-11-24 9:27 ` Andy Shevchenko
2015-11-24 12:22 Jitendra Kumar Khasdev
2015-11-24 12:31 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56535DD5.9060208@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jitendra.khasdev@hotwaxsystems.com \
--cc=jkhasdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.