From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0xMS-0000KD-3v for qemu-devel@nongnu.org; Mon, 23 Nov 2015 15:05:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0xMN-0003fG-4K for qemu-devel@nongnu.org; Mon, 23 Nov 2015 15:05:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0xMM-0003fA-Uv for qemu-devel@nongnu.org; Mon, 23 Nov 2015 15:05:11 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 014D430C7A2 for ; Mon, 23 Nov 2015 20:05:09 +0000 (UTC) References: <1448300659-23559-1-git-send-email-pbonzini@redhat.com> <1448300659-23559-3-git-send-email-pbonzini@redhat.com> <565353ED.1090502@redhat.com> From: Eric Blake Message-ID: <56537170.8070600@redhat.com> Date: Mon, 23 Nov 2015 13:05:04 -0700 MIME-Version: 1.0 In-Reply-To: <565353ED.1090502@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="onfF39FL0HlBsKcomF3FRaxP5NonITijC" Subject: Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , Paolo Bonzini , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --onfF39FL0HlBsKcomF3FRaxP5NonITijC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/23/2015 10:59 AM, Laszlo Ersek wrote: > On 11/23/15 18:44, Paolo Bonzini wrote: >> JSON is LL(1) and our parser indeed needs only 1 token lookahead. >> Saving the parser context is mostly unnecessary; we can replace it >> with peeking at the next token, or remove it altogether when the >> restore only happens on errors. The token list is destroyed anyway >> on errors. >> >> The only interesting thing is that parse_keyword always eats >> a TOKEN_KEYWORD, even if it is invalid, so it must come last in >> parse_value (otherwise, NULL is returned, parse_literal is invoked >> and it tries to peek beyond end of input). This is caught by >> /errors/unterminated/literal, which actually checks for an unterminate= d >> keyword. =E0=B2=A0_=E0=B2=A0 >=20 > Is it accepted practice to put UTF-8 in commit messages? (Or, actually,= > anywhere in patches, except maybe the notes section?) >=20 Git handles UTF-8 just fine (and for any other encoding, properly transmitted in the email, git transcodes to UTF-8 before writing it into the repository). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --onfF39FL0HlBsKcomF3FRaxP5NonITijC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWU3FwAAoJEKeha0olJ0NqQlAH/2vh2nc3cTilBe8TZQFGKIuh 5l3VGEtAkQ/unsKTc9/IdfA2Bl403NTGpXUjRKc7qh+KljEyAjWdqmsJ1dhmlS9v TUG27+LsqPGc2xBPH5XefvlFaduTAftd1Z6yezheWjsdZIW5J/SqSv+p9G/ioTeL n5H2cEJO+CB0NPEV7hUYaccaGBGD6GkBL/TBLoo76BCAVpGvy7e14buXP+q2Xp6I TXjV041T5HEu9p2KCxGwBxK3UqgTREz78k+I1UFRbeQ3xPdcemSdYwZyBxDs91Ge GS7+Zp75mfAnZs7N5YrurIVVbgIa3kp/b6hNMRQFph6Xv5SgJF/nVbdFf2VSEmM= =/buB -----END PGP SIGNATURE----- --onfF39FL0HlBsKcomF3FRaxP5NonITijC--