From: "Bendik Rønning Opstad" <bro.devel@gmail.com>
To: "Eric Dumazet" <eric.dumazet@gmail.com>,
"Bendik Rønning Opstad" <bro.devel@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, "Yuchung Cheng" <ycheng@google.com>,
"Neal Cardwell" <ncardwell@google.com>,
"Andreas Petlund" <apetlund@simula.no>,
"Carsten Griwodz" <griff@simula.no>,
"Pål Halvorsen" <paalh@simula.no>,
"Jonas Markussen" <jonassm@ifi.uio.no>,
"Kristian Evensen" <kristian.evensen@gmail.com>,
"Kenneth Klette Jonassen" <kennetkl@ifi.uio.no>
Subject: Re: [PATCH RFC v2 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)
Date: Mon, 23 Nov 2015 21:05:44 +0100 [thread overview]
Message-ID: <56537198.4000809@gmail.com> (raw)
In-Reply-To: <1448300602.22599.292.camel@edumazet-glaptop2.roam.corp.google.com>
On 23/11/15 18:43, Eric Dumazet wrote:
> On Mon, 2015-11-23 at 17:26 +0100, Bendik Rønning Opstad wrote:
>
>> > +
>> > +tcp_rdb_max_skbs - INTEGER
>> > + Enable restriction on how many previous SKBs in the output queue
>> > + RDB may include data from. A value of 1 will restrict bundling to
>> > + only the data from the last packet that was sent.
>> > + Default: 1
>> > +
> skb is an internal thing. I would rather not expose a sysctl with such
> name.
>
> Can be multi segment or not (if GSO/TSO is enabled)
>
> So even '1' skb can have very different content, from 1 byte to ~64 KB
I see your point about not exposing the internal naming. What about
tcp_rdb_max_packets?
next prev parent reply other threads:[~2015-11-23 20:05 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 20:50 [PATCH RFC net-next 0/2] tcp: Redundant Data Bundling (RDB) Bendik Rønning Opstad
2015-10-23 20:50 ` Bendik Rønning Opstad
2015-10-23 20:50 ` [PATCH RFC net-next 1/2] tcp: Add DPIFL thin stream detection mechanism Bendik Rønning Opstad
2015-10-23 20:50 ` Bendik Rønning Opstad
2015-10-23 21:44 ` Eric Dumazet
2015-10-23 21:44 ` Eric Dumazet
[not found] ` <1445636654.22974.193.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-10-25 5:56 ` Bendik Rønning Opstad
2015-10-25 5:56 ` Bendik Rønning Opstad
2015-10-23 20:50 ` [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB) Bendik Rønning Opstad
2015-10-23 20:50 ` Bendik Rønning Opstad
2015-10-26 14:50 ` Neal Cardwell
2015-10-26 14:50 ` Neal Cardwell
2015-10-26 21:35 ` Andreas Petlund
2015-10-26 21:35 ` Andreas Petlund
2015-10-26 21:58 ` Yuchung Cheng
2015-10-26 21:58 ` Yuchung Cheng
2015-10-27 19:15 ` Jonas Markussen
2015-10-27 19:15 ` Jonas Markussen
2015-10-29 22:53 ` Bendik Rønning Opstad
2015-10-29 22:53 ` Bendik Rønning Opstad
2015-11-02 9:18 ` David Laight
2015-11-02 9:18 ` David Laight
2015-11-02 9:37 ` David Laight
2015-11-02 9:37 ` David Laight
2015-11-05 2:06 ` Bendik Rønning Opstad
2015-11-05 2:06 ` Bendik Rønning Opstad
2015-11-05 2:06 ` Bendik Rønning Opstad
2015-10-24 6:11 ` [PATCH RFC net-next 0/2] tcp: " Yuchung Cheng
2015-10-24 6:11 ` Yuchung Cheng
2015-10-24 6:11 ` Yuchung Cheng
2015-10-24 8:00 ` Jonas Markussen
2015-10-24 8:00 ` Jonas Markussen
[not found] ` <61F74109-9FDC-485A-978B-714B7AA27445-6miFZF/5cTBuMpJDpNschA@public.gmane.org>
2015-10-24 12:57 ` Eric Dumazet
2015-10-24 12:57 ` Eric Dumazet
2015-11-09 19:40 ` Bendik Rønning Opstad
2015-11-23 16:26 ` [PATCH RFC v2 " Bendik Rønning Opstad
2015-11-23 16:26 ` [PATCH RFC v2 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism Bendik Rønning Opstad
2015-11-23 16:26 ` [PATCH RFC v2 net-next 2/2] tcp: Add Redundant Data Bundling (RDB) Bendik Rønning Opstad
2015-11-23 17:43 ` Eric Dumazet
2015-11-23 20:05 ` Bendik Rønning Opstad [this message]
2016-02-02 19:23 ` [PATCH v3 net-next 0/2] tcp: " Bendik Rønning Opstad
2016-02-02 19:23 ` [PATCH v3 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism Bendik Rønning Opstad
2016-02-02 19:23 ` [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB) Bendik Rønning Opstad
2016-02-02 20:35 ` Eric Dumazet
2016-02-03 18:17 ` Bendik Rønning Opstad
2016-02-03 19:34 ` Eric Dumazet
[not found] ` <CAF8eE=VOuoNLQHtkRwM9ZG+vJ-uH2ufVW5y_pS24rGqWh4Qa2g@mail.gmail.com>
2016-02-08 17:30 ` Bendik Rønning Opstad
2016-02-08 17:38 ` Bendik Rønning Opstad
2016-02-16 13:51 ` [PATCH v4 net-next 0/2] tcp: " Bendik Rønning Opstad
2016-02-16 13:51 ` [PATCH v4 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism Bendik Rønning Opstad
2016-02-16 13:51 ` [PATCH v4 net-next 2/2] tcp: Add Redundant Data Bundling (RDB) Bendik Rønning Opstad
2016-02-18 15:18 ` Eric Dumazet
2016-02-19 14:12 ` Bendik Rønning Opstad
2016-02-24 21:12 ` [PATCH v5 net-next 0/2] tcp: " Bendik Rønning Opstad
2016-02-24 21:12 ` [PATCH v5 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism Bendik Rønning Opstad
2016-02-24 21:12 ` [PATCH v5 net-next 2/2] tcp: Add Redundant Data Bundling (RDB) Bendik Rønning Opstad
2016-03-02 19:52 ` David Miller
2016-03-02 22:33 ` Bendik Rønning Opstad
2016-03-03 18:06 ` [PATCH v6 net-next 0/2] tcp: " Bendik Rønning Opstad
2016-03-07 19:36 ` David Miller
2016-03-10 0:20 ` Yuchung Cheng
2016-03-10 1:45 ` Jonas Markussen
2016-03-10 2:27 ` Yuchung Cheng
2016-03-12 9:23 ` Jonas Markussen
2016-03-13 23:18 ` Bendik Rønning Opstad
2016-03-14 21:59 ` Yuchung Cheng
2016-03-18 14:25 ` Bendik Rønning Opstad
2016-03-03 18:06 ` [PATCH v6 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism Bendik Rønning Opstad
2016-03-03 18:06 ` [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB) Bendik Rønning Opstad
2016-03-14 21:15 ` Eric Dumazet
2016-03-15 1:04 ` Rick Jones
2016-03-15 18:09 ` Yuchung Cheng
2016-03-18 17:58 ` Bendik Rønning Opstad
2016-03-14 21:54 ` Yuchung Cheng
2016-03-15 0:40 ` Bill Fink
2016-03-17 23:26 ` Bendik Rønning Opstad
2016-03-21 18:54 ` Yuchung Cheng
2016-06-16 17:12 ` Bendik Rønning Opstad
2016-06-22 14:56 ` [PATCH v7 net-next 0/2] tcp: " Bendik Rønning Opstad
2016-06-22 14:56 ` [PATCH v7 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism Bendik Rønning Opstad
2016-06-22 14:56 ` [PATCH v7 net-next 2/2] tcp: Add Redundant Data Bundling (RDB) Bendik Rønning Opstad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56537198.4000809@gmail.com \
--to=bro.devel@gmail.com \
--cc=apetlund@simula.no \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=griff@simula.no \
--cc=jonassm@ifi.uio.no \
--cc=kennetkl@ifi.uio.no \
--cc=kristian.evensen@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=paalh@simula.no \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.