From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org,
Timo Kokkonen <timo.kokkonen@offcode.fi>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v5 5/8] watchdog: Simplify update_worker
Date: Mon, 23 Nov 2015 23:25:12 -0800 [thread overview]
Message-ID: <565410D8.6070508@roeck-us.net> (raw)
In-Reply-To: <20151124071333.GE19888@pengutronix.de>
Hi Uwe,
On 11/23/2015 11:13 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Sun, Nov 22, 2015 at 07:21:02PM -0800, Guenter Roeck wrote:
>> Drop 'cancel' parameter; simply cancel worker unconditionally
>> if not needed.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> This is a good change, but given that watchdog_update_worker is
> introduced in this series it should be squashed accordingly.
>
As I tried to explain, I didn't squash it because, even though
I could not find any trouble with it, I am still not sure if
it may cause trouble or not. As such, I found it better to keep
it separate to make it easier to revert it _if_, as unlikely as
it may be, it should be needed.
Ultimately I'd like to get some input from Wim on this.
Thanks,
Guenter
next prev parent reply other threads:[~2015-11-24 7:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 3:20 [PATCH v5 0/8] watchdog: Add support for keepalives triggered by infrastructure Guenter Roeck
2015-11-23 3:20 ` [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck
2015-11-23 7:53 ` Uwe Kleine-König
2015-11-23 16:14 ` Guenter Roeck
2015-11-23 18:26 ` Uwe Kleine-König
2015-11-23 21:55 ` Guenter Roeck
2015-11-24 7:16 ` Uwe Kleine-König
2015-11-24 15:03 ` Guenter Roeck
2015-11-24 16:11 ` Uwe Kleine-König
2015-11-24 16:45 ` Guenter Roeck
2015-11-24 21:14 ` Uwe Kleine-König
2015-11-23 3:20 ` [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag Guenter Roeck
2015-11-23 16:30 ` Alexander Stein
2015-11-23 16:42 ` Guenter Roeck
2015-11-23 19:26 ` Uwe Kleine-König
2015-11-23 21:48 ` Guenter Roeck
2015-11-23 3:21 ` [PATCH v5 3/8] watchdog: Make set_timeout function optional Guenter Roeck
2015-11-23 3:21 ` [PATCH v5 4/8] watchdog: Add support for minimum time between heartbeats Guenter Roeck
2015-11-23 3:21 ` [PATCH v5 5/8] watchdog: Simplify update_worker Guenter Roeck
2015-11-24 7:13 ` Uwe Kleine-König
2015-11-24 7:25 ` Guenter Roeck [this message]
2015-11-23 3:21 ` [RFT PATCH v5 6/8] watchdog: imx2: Convert to use infrastructure triggered keepalives Guenter Roeck
2015-11-23 3:21 ` [RFT PATCH v5 7/8] watchdog: retu: " Guenter Roeck
2015-11-23 3:21 ` [RFT PATCH v5 8/8] watchdog: at91sam9: " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565410D8.6070508@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=timo.kokkonen@offcode.fi \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.