From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 0/3] drm/amdgpu: enable DKMS build Date: Tue, 24 Nov 2015 11:08:07 +0100 Message-ID: <56543707.9090909@vodafone.de> References: <1448355322-3636-1-git-send-email-Jammy.Zhou@amd.com> <20151124085909.GG17050@phenom.ffwll.local> <20151124093623.GB6149@ulmo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0766018775==" Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D4F46E889 for ; Tue, 24 Nov 2015 02:08:14 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by pegasos-out.vodafone.de (Rohrpostix1 Daemon) with ESMTP id 7A7A2261678 for ; Tue, 24 Nov 2015 11:08:13 +0100 (CET) Received: from pegasos-out.vodafone.de ([127.0.0.1]) by localhost (rohrpostix1.prod.vfnet.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uw0d25z+7Ogm for ; Tue, 24 Nov 2015 11:08:11 +0100 (CET) In-Reply-To: <20151124093623.GB6149@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding , Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============0766018775== Content-Type: multipart/alternative; boundary="------------020807080208050004060401" This is a multi-part message in MIME format. --------------020807080208050004060401 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 24.11.2015 10:36, Thierry Reding wrote: > On Tue, Nov 24, 2015 at 09:59:09AM +0100, Daniel Vetter wrote: >> On Tue, Nov 24, 2015 at 04:55:19PM +0800, Jammy Zhou wrote: >>> This series enable the DKMS build of amdgpu driver. >> For the curious: What's DKMS? > I believe in this context it's "Dynamic Kernel Module Support": > > https://wiki.debian.org/KernelDKMS Yeah, correct. > > I'm somewhat surprised that one would have to do something special to > the kernel build system to "enable" such a build. But perhaps this is > completely unrelated. I'm a bit torn apart on this. On the one hand I'm not sure if we have drivers upstream explicitly supporting this as well? On the other hand it's just the Makefiles which need to be written in a way which makes them relocatable. E.g. no absolute path like drivers/gpu/drm/amd/... in them and that's a good idea anyway. Maybe just changing the commit message to "don't use absolute paths in the makefiles" would be sufficient? Regards, Christian. > > Thierry > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel --------------020807080208050004060401 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

On 24.11.2015 10:36, Thierry Reding wrote:

On Tue, Nov 24, 2015 at 09:59:09AM +0100, Daniel Vetter wrote:

On Tue, Nov 24, 2015 at 04:55:19PM +0800, Jammy Zhou wrote:

This series enable the DKMS build of amdgpu driver.

For the curious: What's DKMS?

I believe in this context it's "Dynamic Kernel Module Support":

	https://wiki.debian.org/KernelDKMS

Yeah, correct.


I'm somewhat surprised that one would have to do something special to
the kernel build system to "enable" such a build. But perhaps this is
completely unrelated.

I'm a bit torn apart on this. On the one hand I'm not sure if we have drivers upstream explicitly supporting this as well?

On the other hand it's just the Makefiles which need to be written in a way which makes them relocatable. E.g. no absolute path like drivers/gpu/drm/amd/... in them and that's a good idea anyway.

Maybe just changing the commit message to "don't use absolute paths in the makefiles" would be sufficient?

Regards,
Christian.


Thierry

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--------------020807080208050004060401-- --===============0766018775== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0766018775==--