From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCHv5] 00/28] Kconfig conversion Date: Tue, 24 Nov 2015 15:58:58 +0000 Message-ID: <56548942.3050206@citrix.com> References: <1448046616-29922-1-git-send-email-cardoe@cardoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1448046616-29922-1-git-send-email-cardoe@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Doug Goldstein , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 20/11/15 19:09, Doug Goldstein wrote: > The following series is a follow on to the Kconfig conversion patch series. > There are still more components to convert however this is the bare minimal > to get everything working and get the options out of the existing makefiles. > > The CONFIG_HAS_ variables are there to match the behavior of the Linux > CONFIG_HAVE_ variables. The purpose is to say that this hardware/profile/env > supports this option while the CONFIG_ variable states that this option was > requested on/off by user intervention. > > The UARTs are now uniformly prefixed as CONFIG_UART_ and dropping most of the > CONFIG_HAS_ labeling for them. This means they are now user selectable as > requested by Julien Grall in the prior review. The question I've got is > the old config was just for selecting defaults. Users could enable the OMAP > UART for arm64 for example but I'm not sure if that's valid. Currently this > patchset makes those UARTs not user selectable if they were not previously > defaulted on. But I would like some feedback on this if possible. > > Ultimately my goal is to allow for more parts of the hypervisor to be turned > off at compile time and potentially make it easier to include more > experimental features by others which can be turned off by default. Also to > provide the one true location for all possible knobs in the source code. > > The patch series can be grabbed at: > https://github.com/cardoe/xen/tree/kconfig_v5 Having had a play with this, everything appears to be in order. Acked-by: Andrew Cooper Tested-by: Andrew Cooper Thankyou very much for your work here.