From: Robert Shearman <rshearma@brocade.com>
To: roopa <roopa@cumulusnetworks.com>
Cc: <ebiederm@xmission.com>, <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v4] mpls: support for dead routes
Date: Tue, 24 Nov 2015 16:46:59 +0000 [thread overview]
Message-ID: <56549483.3080600@brocade.com> (raw)
In-Reply-To: <5653DC6E.9090204@cumulusnetworks.com>
On 24/11/15 03:41, roopa wrote:
> On 11/23/15, 6:15 AM, Robert Shearman wrote:
>> On 21/11/15 05:16, Roopa Prabhu wrote:
>>> + if (!rt_new) {
>>> + pr_warn("mpls_ifdown: kmemdup failed\n");
>>
>> It isn't safe to leave the current route untouched if the net device is being deleted, since a nexthop will be left holding a stale pointer to it. Perhaps delete the route entirely in that case?
> I would not delete the route. But, Would it be bad modifying rt in that case (ie when rt_new is not possible) ?. It is a remote case..and the side effect being the datapath will not see the changes atomically.
No, that sounds fine to me as long as RCU_INIT_POINTER is used.
Thanks,
Rob
prev parent reply other threads:[~2015-11-24 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 5:16 [PATCH net-next v4] mpls: support for dead routes Roopa Prabhu
2015-11-23 14:15 ` Robert Shearman
2015-11-24 3:41 ` roopa
2015-11-24 16:46 ` Robert Shearman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56549483.3080600@brocade.com \
--to=rshearma@brocade.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.