From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Hackmann Subject: Re: [PATCH] staging/android: add TODO to de-stage android sync framework Date: Tue, 24 Nov 2015 08:51:56 -0800 Message-ID: <565495AC.9050008@google.com> References: <1448307713-16766-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DC8F7207D for ; Tue, 24 Nov 2015 08:51:57 -0800 (PST) Received: by pabfh17 with SMTP id fh17so28312006pab.0 for ; Tue, 24 Nov 2015 08:51:56 -0800 (PST) In-Reply-To: <1448307713-16766-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , greg@kroah.com Cc: daniels@collabora.com, Daniel Vetter , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gMTEvMjMvMTUgMTE6NDEgQU0sIEd1c3Rhdm8gUGFkb3ZhbiB3cm90ZToKPiArIC0gcmVtb3Zl IHN3X3N5bmMsIGl0IGlzIHVzZWQgb25seSBmb3IgdGVzdGluZy9kZWJ1Z2dpbmcgYW5kIHNob3Vs ZCBub3QgYmUKPiArdXBzdHJlYW1lZC4KPiArIC0gcG9ydCBzd19zeW5jIHRlc3RjYXNlcyB0byB1 c2UgZGVidWdmcyBzb21laG93CgpBIHF1aWNrIGJ1dCBpbXBvcnRhbnQgbml0cGljazoKCnN3X3N5 bmMgaXRzZWxmIGlzIGp1c3QgYW4gaW4ta2VybmVsIGhlbHBlciBmb3IgY3JlYXRpbmcgZmVuY2Vz LCB3aGVuIHlvdSAKZG9uJ3QgaGF2ZSBzb21ldGhpbmcgbGlrZSBzeW5jIHRpbWVsaW5lIHByaW1p dGl2ZXMgYmFrZWQgaW50byB5b3VyIGhhcmR3YXJlLgoKQ09ORklHX1NXX1NZTkNfVVNFUiBhZGRz IHRoZSBpbnRlcmZhY2UgZm9yIGNyZWF0aW5nIGFuZCBzaWduYWxpbmcgCnN3X3N5bmMgb2JqZWN0 cyBmcm9tIHVzZXJzcGFjZS4gIFRoaXMgaXMgdGhlIHBhcnQgdGhhdCdzIGRhbmdlcm91cyBhbmQg Cm9ubHkgaW50ZW5kZWQgZm9yIHRlc3RpbmcsIGV0Yy4KCkFGQUlLIENPTkZJR19TV19TWU5DX1VT RVIgaXMgdGhlIG9ubHkgcGFydCBwZW9wbGUgaGF2ZSBiZWVuIG9iamVjdGluZyAKdG8uICBJJ20g ZmluZSB3aXRoIHJlbW92aW5nIGl0LiAgUmVtb3ZpbmcgdGhlIGtlcm5lbC1mYWNpbmcgc2lkZSBv ZiAKc3dfc3luYyB3b3VsZCBiZSBhIHByb2JsZW0gZm9yIHVzLCBzaW5jZSBtYW55IGRyaXZlcnMg dXNlIGl0IHRvIGNyZWF0ZSAKdGhlaXIgZmVuY2VzLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754479AbbKXQv6 (ORCPT ); Tue, 24 Nov 2015 11:51:58 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36624 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754068AbbKXQv5 (ORCPT ); Tue, 24 Nov 2015 11:51:57 -0500 Subject: Re: [PATCH] staging/android: add TODO to de-stage android sync framework To: Gustavo Padovan , greg@kroah.com References: <1448307713-16766-1-git-send-email-gustavo@padovan.org> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Gustavo Padovan , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , John Harrison From: Greg Hackmann Message-ID: <565495AC.9050008@google.com> Date: Tue, 24 Nov 2015 08:51:56 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448307713-16766-1-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/15 11:41 AM, Gustavo Padovan wrote: > + - remove sw_sync, it is used only for testing/debugging and should not be > +upstreamed. > + - port sw_sync testcases to use debugfs somehow A quick but important nitpick: sw_sync itself is just an in-kernel helper for creating fences, when you don't have something like sync timeline primitives baked into your hardware. CONFIG_SW_SYNC_USER adds the interface for creating and signaling sw_sync objects from userspace. This is the part that's dangerous and only intended for testing, etc. AFAIK CONFIG_SW_SYNC_USER is the only part people have been objecting to. I'm fine with removing it. Removing the kernel-facing side of sw_sync would be a problem for us, since many drivers use it to create their fences.