From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nyushchenko@dev.rtsoft.ru>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id C5DF7E00B45; Tue, 24 Nov 2015 09:04:50 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.1
X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
Received: from dev.rtsoft.ru (mail.dev.rtsoft.ru [213.79.90.226])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id ED3BAE00B9A
	for <meta-freescale@yoctoproject.org>;
	Tue, 24 Nov 2015 09:04:37 -0800 (PST)
Received: from [192.168.112.12] (fw-int.dev.rtsoft.ru [192.168.1.70])
	by dev.rtsoft.ru (Postfix) with ESMTP id 5800043510;
	Tue, 24 Nov 2015 20:04:32 +0300 (MSK)
Message-ID: <5654989F.6030009@dev.rtsoft.ru>
Date: Tue, 24 Nov 2015 20:04:31 +0300
From: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
Organization: RTSoft Software Development Center
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version: 1.0
To: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Cc: Gennady Kuznetsov <kuznetsovg@dev.rtsoft.ru>,
	Andrey Rusalin <arusalin@dev.rtsoft.ru>
Subject: imx6dl.dtsi gpu clock definition bug
X-BeenThere: meta-freescale@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Usage and development list for the meta-fsl-* layers
	<meta-freescale.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/meta-freescale>,
	<mailto:meta-freescale-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/meta-freescale>
List-Post: <mailto:meta-freescale@yoctoproject.org>
List-Help: <mailto:meta-freescale-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/meta-freescale>,
	<mailto:meta-freescale-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Nov 2015 17:04:50 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi

Both in linux-imx branch imx_3.14.28_1.0.0_ga, and in linux-fslc branch
3.14-1.0.x-mx6, in arch/arm/boot/dts/imx6dl.dtsi file, in gpu@00130000,
clock definition is inconsistent:

clocks = <&clks IMX6QDL_CLK_OPENVG_AXI>, <&clks IMX6QDL_CLK_GPU3D_AXI>,
         <&clks IMX6QDL_CLK_GPU2D_CORE>, <&clks IMX6QDL_CLK_GPU3D_CORE>,
         <&clks IMX6QDL_CLK_DUMMY>;
clock-names = "gpu2d_axi_clk", "gpu3d_axi_clk",
              "gpu2d_clk", "gpu3d_clk",
              "gpu3d_shader_clk";

i.e first entry in "clocks" refers to openvg_axi clk, but name refers to
gpu2d_axi clk


This causes

[    1.331535] galcore: clk_get vg clock failed, disable vg!

and may cause unknown misfunctions.


Corresponding part of arch/arm/boot/dts/imx6q.dtsi file:

clocks = <&clks IMX6QDL_CLK_GPU2D_AXI>, <&clks IMX6QDL_CLK_OPENVG_AXI>,
         <&clks IMX6QDL_CLK_GPU3D_AXI>, <&clks IMX6QDL_CLK_GPU2D_CORE>,
       <&clks IMX6QDL_CLK_GPU3D_CORE>, <&clks IMX6QDL_CLK_GPU3D_SHADER>;
clock-names = "gpu2d_axi_clk", "openvg_axi_clk",
              "gpu3d_axi_clk", "gpu2d_clk",
              "gpu3d_clk", "gpu3d_shader_clk";


Is definition of 5 clocks instead of 6 in imx6dl.dtsi intensional?
If so - which one clock should be missing, gpu2d_axi or openvg_axi?