From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 3/4] gdbsx: prefer privcmd character device Date: Tue, 24 Nov 2015 14:11:44 -0600 Message-ID: <5654C480.3080606@cardoe.com> References: <1448390855-13505-1-git-send-email-cardoe@cardoe.com> <1448390855-13505-3-git-send-email-cardoe@cardoe.com> <22100.45608.914912.205420@mariner.uk.xensource.com> <5654B84E.3020306@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5409376644462208924==" Return-path: In-Reply-To: <5654B84E.3020306@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Mukesh Rathor , Stefano Stabellini , Wei Liu , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5409376644462208924== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RjpAx2px82cFudiedHkNqr5AqVJcJuA8a" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RjpAx2px82cFudiedHkNqr5AqVJcJuA8a Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/24/15 1:19 PM, Doug Goldstein wrote: > On 11/24/15 12:53 PM, Ian Jackson wrote: >> Doug Goldstein writes ("[PATCH 3/4] gdbsx: prefer privcmd character de= vice"): >>> Prefer using the character device over the proc file if the character= >>> device exists. >> >> I think this common logic (which also appears in your 1/4 patch) >> should be factored out. >> >> Could gdbsx not use a libxc handle ? >> >> Ian. >> >=20 > I agree. I actually emailed the maintainer about this but his address > bounced so I left it as the simpler patch instead. I can make that > chance and resubmit if you'd prefer. >=20 I'll just drop this out of the v2 and look at improving it in another series. --=20 Doug Goldstein --RjpAx2px82cFudiedHkNqr5AqVJcJuA8a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWVMSDXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUUXAP/3atCYrENwbyd2oS8BDMDTC/ uoFBY31I4FiT/dzRkXVyWizw3D0HVlfAP8Mxx6DD638ZUtBtnpUDVF7SQ2f412g9 nG0N1eua5GaKrXCzRf0eAVuX2Cokfa9KmD4d4UKzQQq6F9kx138OrE+boKJAwVrT tsFBO8LreMciyRFcFnF6/8Z73+2K+ihsOtg3pYKMdM/UIv+3Zu9u4nfVe5HpUF6E aEB17NXsLB6Be/8GPUo3wAgDdLXvWPCsAYD2u64qrsEk7T+/E0N+BSxgC9T1IWk5 Io8gHoVpuq/1f4M1ehCDdk/EQCHs1TlKe9WBDt6j77qjsCkzZN1IObnrOhbeh0/m Jo761t3pyQXaGcGrNr3JbzxlzTEMTTRUwSry4N8cZvQjF5OgndlaI9GmiavAOkSN JxMrPao9ElvAYWLCP4B5lGVED9Ah8DMT2SH2jgEA3dtbs/ezqLohCBMzpGpupuKe YgNfUUVDnDEREM402P7bVA2A3gwuSgDobHCo6QhLI0QiF+H7AU2v9Qn21me3pkvK YROEBq8X9WFLVC7yaslhbMM6LnWEHMBp0ocGXUS2iblEewQFKigR7sPLPK2wIW2e 290f0lEudjUIbRQUxsE2ArQsNtnCSgMOXr5xjKQ2tNmhWvyAwnNQ+sATcLpf6A5r toTISzSgRLWn9SbG1r27 =4hEq -----END PGP SIGNATURE----- --RjpAx2px82cFudiedHkNqr5AqVJcJuA8a-- --===============5409376644462208924== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5409376644462208924==--