From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1KV9-0004ZS-QQ for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:47:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1KV8-0007c4-Op for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:47:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1KV8-0007c0-J2 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:47:46 -0500 References: <1448388281-18691-1-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <5654CCF1.8040709@redhat.com> Date: Tue, 24 Nov 2015 13:47:45 -0700 MIME-Version: 1.0 In-Reply-To: <1448388281-18691-1-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ldns4k0JViR7F45UHA0vhnlc1AqDaJaDs" Subject: Re: [Qemu-devel] [PATCH for-2.5 v2 0/2] qga: flush explicitly when needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ldns4k0JViR7F45UHA0vhnlc1AqDaJaDs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2015 11:04 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Without this change, a write() followed by a read() may lose the > previously written content, as shown in the following test. >=20 > v1->v2: > - replace guchar with unsigned char > - fix implicitly/explictly > - comment space fix Counts as a bug fix, so I'm suggesting that this series goes in 2.5; although the behavior itself has been broken for a longer time so it is not critical if it stalls until 2.6. >=20 > Marc-Andr=C3=A9 Lureau (2): > qga: flush explicitly when needed > tests: add file-write-read test >=20 > qga/commands-posix.c | 22 ++++++++++++ > tests/test-qga.c | 95 ++++++++++++++++++++++++++++++++++++++++++++= ++++++-- > 2 files changed, 115 insertions(+), 2 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ldns4k0JViR7F45UHA0vhnlc1AqDaJaDs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVMzxAAoJEKeha0olJ0Nqwz0H/3fvmNJ8zgGZeh8AYDvSkGfZ F+DRYTJuqujWoJhTG9ZVcrY3WZMlMpfWF9BRS6+rMKqJNt7MqQQnqYyYM6NB6WDH XuflS0OSHTvhKZa13mTNyeEAhPnl9CqgStsbss07hmB+rgJLpKtWn5/GkbtXxeRr /gArIkpXro2hVKPC8RXEw5UVnbQJxKGDR+X5+mN9nwY0m/CqupzzPaVz7KOqchcN iFi62rzN/tEPy2zoAsp3dkxKfZ53aq/gs4kbhAiUKHGPvQrfQYlc4rv0+bezxc6p c10UBambv7V/keZYndNqDuesnon6ISK09RAJT7pm1/f6CX41pcU8bJhg/P1NKsM= =t9kM -----END PGP SIGNATURE----- --ldns4k0JViR7F45UHA0vhnlc1AqDaJaDs--