From: axboe@fb.com (Jens Axboe)
Subject: [PATCH] NVMe: Shutdown fixes
Date: Tue, 24 Nov 2015 18:39:54 -0700 [thread overview]
Message-ID: <5655116A.4060407@fb.com> (raw)
In-Reply-To: <1448407814-12544-1-git-send-email-keith.busch@intel.com>
On 11/24/2015 04:30 PM, Keith Busch wrote:
> The controller must be disabled prior to completing a presumed lost
> command. This patch makes the shutdown safe to simultaneous invocations
> using mutex, and directly calls shutdown from the timeout handler if
> timeout occurs.
>
> The driver must directly set req->errors to get the appropriate status
> propogated to the caller, since the timeout handler already set the
> targeted request to "complete". The shutdown unconditionally clears
> all outstanding commands, so it is safe to return "EH_HANDLED" from the
> timeout handler and assume the command was completed.
Much better, looks good to me.
--
Jens Axboe
next prev parent reply other threads:[~2015-11-25 1:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 23:30 [PATCH] NVMe: Shutdown fixes Keith Busch
2015-11-25 1:39 ` Jens Axboe [this message]
2015-11-25 8:55 ` Christoph Hellwig
2015-11-25 16:05 ` Keith Busch
2015-11-25 16:42 ` Christoph Hellwig
2015-11-25 16:57 ` Keith Busch
2015-11-25 17:08 ` Christoph Hellwig
2015-11-25 17:28 ` Keith Busch
2015-11-25 17:55 ` Christoph Hellwig
2015-11-25 18:24 ` Keith Busch
2015-11-25 19:38 ` Christoph Hellwig
2015-11-30 8:47 ` Christoph Hellwig
2015-11-30 21:42 ` Keith Busch
2015-12-01 12:36 ` Christoph Hellwig
2015-12-07 14:12 ` Christoph Hellwig
2015-12-07 22:19 ` Keith Busch
2015-12-09 18:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5655116A.4060407@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.