All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mason <slash.tmp@free.fr>
To: Mans Rullgard <mans@mansr.com>, linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller
Date: Wed, 25 Nov 2015 13:10:31 +0100	[thread overview]
Message-ID: <5655A537.3040707@free.fr> (raw)
In-Reply-To: <56558E13.6030703@free.fr>

> +	status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS);
> +	status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS);

In my local branch, I wrote:

#define IRQ_CTL_LO	0

	status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS);
	status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS);

(I'm a sucker for symmetry)

Regards.


  reply	other threads:[~2015-11-25 12:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 18:33 [PATCH 0/2] Support for Sigma Designs SMP86xx interrupt controller Mans Rullgard
2015-11-19 18:33 ` [PATCH 1/2] devicetree: add binding " Mans Rullgard
     [not found]   ` <1447958026-3015-2-git-send-email-mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
2015-11-20 16:23     ` Rob Herring
2015-11-20 16:23       ` Rob Herring
2015-11-20 16:27       ` Måns Rullgård
2015-11-20 16:27         ` Måns Rullgård
2015-11-19 18:33 ` [PATCH 2/2] irqchip: add support " Mans Rullgard
2015-11-20 10:13   ` Marc Zyngier
     [not found]     ` <564EF235.7030207-5wv7dgnIgG8@public.gmane.org>
2015-11-20 12:00       ` Måns Rullgård
2015-11-20 12:00         ` Måns Rullgård
     [not found]   ` <1447958026-3015-3-git-send-email-mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
2015-11-20 12:03     ` Mason
2015-11-20 12:03       ` Mason
     [not found]       ` <564F0BFD.3090703-GANU6spQydw@public.gmane.org>
2015-11-20 12:15         ` Måns Rullgård
2015-11-20 12:15           ` Måns Rullgård
2015-11-25 10:31   ` Mason
2015-11-25 12:10     ` Mason [this message]
2015-11-25 12:12       ` Måns Rullgård
2015-11-26 10:25         ` Mason
2015-11-26 10:50           ` Måns Rullgård
2015-11-25 12:11     ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5655A537.3040707@free.fr \
    --to=slash.tmp@free.fr \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=marc.zyngier@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.