From mboxrd@z Thu Jan 1 00:00:00 1970 From: Malcolm Crossley Subject: Re: [PATCHv2 3/3] p2m: convert grant table rwlock to percpu rwlock Date: Wed, 25 Nov 2015 12:54:01 +0000 Message-ID: <5655AF69.7060505@citrix.com> References: <1448035423-24242-1-git-send-email-malcolm.crossley@citrix.com> <1448035423-24242-4-git-send-email-malcolm.crossley@citrix.com> <5655B9ED02000078000B8FC2@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a1ZaI-0001Dj-RB for xen-devel@lists.xenproject.org; Wed, 25 Nov 2015 12:54:06 +0000 In-Reply-To: <5655B9ED02000078000B8FC2@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, ian.campbell@citrix.com, george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, Marcos.Matsunaga@oracle.com, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 25/11/15 12:38, Jan Beulich wrote: >>>> On 20.11.15 at 17:03, wrote: >> @@ -115,7 +117,7 @@ static inline void _mm_write_lock(mm_rwlock_t *l, const char *func, int level) >> if ( !mm_write_locked_by_me(l) ) >> { >> __check_lock_level(level); >> - write_lock(&l->lock); >> + percpu_write_lock(p2m_percpu_rwlock, &l->lock); > > A hard tab slipped in here. I'll fix that up, I've also modified my editor setup so this (hopefully) doesn't happen again. Thanks Malcolm > Jan >