Re: J1939 crash after receiving BAM frame and no DT frame

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]

On 11/25/2015 02:39 PM, laurent vaudoit wrote:
>>> i have found a workaround, working with rtpatch, but not sure if this
>>> can be considered as a bug fix or not.
>>> in function j1939tp_rxtask, there is a call to j1939session_cancel,
>>> who call put_session
>>> and at the end of j1939tp_rxtask, we call put_session.
>>> if i comment this "second call" to put_session, the problem disappear.
>>
>> It seems that you added a memory leak because put_session if a ref
>> counter. You keep the session installed ... forever, or until a next
>> similar session is about to be created.
>>
>> I'm not sure either that this is the correct way to proceed.
> 
> i'm not sure i understand well.
> this seems weird for me to have one get_session and 2 put_session
> should'nt we have one get_session and one put_session only? (this is
> what i tried)?

Maybe copy/pasting your patch here make the discussion easier :)

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]