From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1cX7-0005qJ-6o for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:03:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1cX3-0001jQ-Am for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:03:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1cX3-0001iP-5V for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:02:57 -0500 References: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com> <1448456352-14143-3-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <5655DBAF.3040506@redhat.com> Date: Wed, 25 Nov 2015 09:02:55 -0700 MIME-Version: 1.0 In-Reply-To: <1448456352-14143-3-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L2wGJGIkWmKNu3JltnwPrSLQKto87V7Ws" Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L2wGJGIkWmKNu3JltnwPrSLQKto87V7Ws Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2015 05:59 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > This test exhibits a POSIX behaviour regarding switching between write > and read. It's undefined result if the application doesn't ensure a > flush between the two operations (with glibc, the flush can be implicit= > when the buffer size is relatively small). The previous commit fixes > this test. >=20 > Related to: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1210246 >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > tests/test-qga.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++-- > 1 file changed, 93 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake > + /* seek to 0 */ > + cmd =3D g_strdup_printf("{'execute': 'guest-file-seek'," > + " 'arguments': { 'handle': %" PRId64 ", " > + " 'offset': %d, 'whence': %d } }", > + id, 0, SEEK_SET); We still have a conflict between this series and my proposal to codify 0 rather than relying on platform-specific SEEK_SET; Markus had the suggestion of using QGA_SET (or QGA_SEEK_SET). Are we trying to get both your series and my v2 patch into 2.5? Knowing that will help me decide whether my v2 should be rebased on top of your patches. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --L2wGJGIkWmKNu3JltnwPrSLQKto87V7Ws Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVduvAAoJEKeha0olJ0NquwwIAIuPYg/u/YoRkxmY8AD/tvxp xQnpSImnQGeOXZkxZaBMnhwR3aTs+AJZdhBCvJA0l+Oa7q8b+r8vtbSdvIvEUXmm 55R74haLoNmGVLXZ1I9+X7jafhWAsgZQphBHXhI9Fm0JUi97IQB9E24QIiOOImPG 3jprVpQuWZzlOithMVBu9JyhMxugR+u0ixKewail5Ft9Z4pAh/edOl54f5hGSpdq P00kxhnNvue+5gfHdCCJpeKdu4esV30c5Lxj3/5NTkUOg9bgjjVE0U7ySQRHmyZ9 rxMfHtQD6C4uz8vS/ZdgF4faPZjReLu1RRrjs42OE+hrZ7YQxgv3Dj+mLvzFJRw= =M7pt -----END PGP SIGNATURE----- --L2wGJGIkWmKNu3JltnwPrSLQKto87V7Ws--