From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1d8W-0003ex-EY for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:41:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1d8T-0004aJ-6y for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:41:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1d8T-0004aE-1m for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:41:37 -0500 References: <1448456352-14143-1-git-send-email-marcandre.lureau@redhat.com> <1448456352-14143-3-git-send-email-marcandre.lureau@redhat.com> <5655DBAF.3040506@redhat.com> <20151125162102.6284.38229@loki> From: Eric Blake Message-ID: <5655E4BF.3010604@redhat.com> Date: Wed, 25 Nov 2015 09:41:35 -0700 MIME-Version: 1.0 In-Reply-To: <20151125162102.6284.38229@loki> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4mEhesb2XGa02l5oJo1hf8IddqgJEqdXd" Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4mEhesb2XGa02l5oJo1hf8IddqgJEqdXd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2015 09:21 AM, Michael Roth wrote: >>> + /* seek to 0 */ >>> + cmd =3D g_strdup_printf("{'execute': 'guest-file-seek'," >>> + " 'arguments': { 'handle': %" PRId64 ", " >>> + " 'offset': %d, 'whence': %d } }", >>> + id, 0, SEEK_SET); >> >> We still have a conflict between this series and my proposal to codify= 0 >> rather than relying on platform-specific SEEK_SET; Markus had the >> suggestion of using QGA_SET (or QGA_SEEK_SET). Are we trying to get >> both your series and my v2 patch into 2.5? Knowing that will help me >> decide whether my v2 should be rebased on top of your patches. >=20 > I was planning on pulling in your patch on top of this for the next > 2.5 pull, so rebasing on top of this series is probably best. Okay, will do, and will do quickly so I'm not holding up your pull reques= t. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4mEhesb2XGa02l5oJo1hf8IddqgJEqdXd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVeS/AAoJEKeha0olJ0NqDp0IAKiBqIa38RCROusK+binTv13 TNLe/yWYUnfW+W2yvN922dDeB5J3ddw7kM+tvKGziTcusyx60/vJwZdVoH3Bc5eb yZfaOCBfRsrcrkn3q/LIOq1syau24ddPWqIn+D8SdOukImLoMUSfEQnB35qUGu9z p9vNN84h66cNPiegEfzT5JuJCxgAE+BoTXoOkbifrMQlJOjri3AIyfb7d9pehDc1 9D4xozmHfyytktim2US6Fc8lxZ5cIFIlcAxybthZes+gPOU8J/ke+JG5F9A6Tzwk 8cuajmmGpLxcHIw3GyQNsmPgxJJ7xqYZpjy1kus6fULtVp0TWoIc912ucjkoO4Q= =YMC4 -----END PGP SIGNATURE----- --4mEhesb2XGa02l5oJo1hf8IddqgJEqdXd--