Re: [Qemu-devel] [PATCH v3 for-2.5 04/12] qjson: Spell out some silent assumptions

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

On 11/25/2015 02:23 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/qapi/qmp/json-lexer.h | 3 ++-
>  qobject/json-lexer.c          | 7 ++++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)

>  
> +QEMU_BUILD_BUG_ON((int)JSON_MIN <= (int)IN_START);

I see why the casts are needed here (otherwise, you are comparing two
different enum types, which can trigger warnings).  Perhaps one cast is
sufficient, but using both is consistent.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]