From: Eric Blake <eblake@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>,
Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host
Date: Wed, 25 Nov 2015 21:29:18 -0700 [thread overview]
Message-ID: <56568A9E.3020902@redhat.com> (raw)
In-Reply-To: <5656892E.9020908@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On 11/25/2015 09:23 PM, Eric Blake wrote:
>> +static kern_return_t FindEjectableOpticalMedia(io_iterator_t *mediaIterator,
>> + char *mediaType)
>
> Unusual indentation; more typical is:
>
> | static kern_return_t FindEjectableOpticalMedia(io_iterator_t
> *mediaIterator,
> | char *mediatType)
And then my mailer messes it up :(
> static kern_return_t FindEjectableOpticalMedia(io_iterator_t *mediaIterator,
> char *mediatType)
Let's see if that's better (the 'char' is directly beneath the
'io_iterator_t').
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-26 4:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 4:10 [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host Programmingkid
2015-11-26 4:23 ` Eric Blake
2015-11-26 4:29 ` Eric Blake [this message]
2015-11-27 21:24 ` Programmingkid
2015-11-27 19:35 ` Programmingkid
2015-11-30 16:19 ` Eric Blake
2015-11-30 16:26 ` Kevin Wolf
2015-11-30 16:38 ` Programmingkid
2015-11-30 16:49 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56568A9E.3020902@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.