From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 26 Nov 2015 06:16:44 +0100 (CET) Received: from exsmtp01.microchip.com ([198.175.253.37]:22503 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27006508AbbKZFQmEf6rc (ORCPT ); Thu, 26 Nov 2015 06:16:42 +0100 Received: from [127.0.0.1] (10.10.76.4) by CHN-SV-EXCH01.mchp-main.com (10.10.76.37) with Microsoft SMTP Server id 14.3.181.6; Wed, 25 Nov 2015 22:16:34 -0700 Subject: Re: [PATCH 12/14] DEVICETREE: Add bindings for PIC32 SDHC host controller To: Rob Herring References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-13-git-send-email-joshua.henderson@microchip.com> <20151122215737.GA5285@rob-hp-laptop> CC: , , Andrei Pistirica , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , From: Joshua Henderson Message-ID: <565695B0.8090704@microchip.com> Date: Wed, 25 Nov 2015 22:16:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151122215737.GA5285@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 50128 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: joshua.henderson@microchip.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Rob, On 11/22/2015 2:57 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:24PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica >> >> Document the devicetree bindings for the SDHC peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson >> --- >> .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> new file mode 100644 >> index 0000000..f16388c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> @@ -0,0 +1,24 @@ >> +* Microchip PIC32 SDHCI Controller >> + >> +This file documents differences between the core properties in mmc.txt >> +and the properties used by the sdhci-pic32 driver. >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-sdhci" >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for data and command lines >> + >> +Optional properties: >> +- no-1-8-v: 1.8V voltage selection not supported > > There's a standard property for this one. > Correct. This is indeed a standard property that should not be here. There is currently discussion to avoid using this property anyway. >> +- piomode: disable DMA support > > Proably this one too IIRC. > We will be dropping this. There are other ways to accomplish the same thing outside of DT. Josh From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from exsmtp01.microchip.com ([198.175.253.37]:22503 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27006508AbbKZFQmEf6rc (ORCPT ); Thu, 26 Nov 2015 06:16:42 +0100 Subject: Re: [PATCH 12/14] DEVICETREE: Add bindings for PIC32 SDHC host controller References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-13-git-send-email-joshua.henderson@microchip.com> <20151122215737.GA5285@rob-hp-laptop> From: Joshua Henderson Message-ID: <565695B0.8090704@microchip.com> Date: Wed, 25 Nov 2015 22:16:32 -0700 MIME-Version: 1.0 In-Reply-To: <20151122215737.GA5285@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Rob Herring Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Andrei Pistirica , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org Message-ID: <20151126051632.KPML5mCh9j04heMlLJDH31Zh9Pq1wF-AtSMD0gCIROs@z> Hi Rob, On 11/22/2015 2:57 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:24PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica >> >> Document the devicetree bindings for the SDHC peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson >> --- >> .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> new file mode 100644 >> index 0000000..f16388c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> @@ -0,0 +1,24 @@ >> +* Microchip PIC32 SDHCI Controller >> + >> +This file documents differences between the core properties in mmc.txt >> +and the properties used by the sdhci-pic32 driver. >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-sdhci" >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for data and command lines >> + >> +Optional properties: >> +- no-1-8-v: 1.8V voltage selection not supported > > There's a standard property for this one. > Correct. This is indeed a standard property that should not be here. There is currently discussion to avoid using this property anyway. >> +- piomode: disable DMA support > > Proably this one too IIRC. > We will be dropping this. There are other ways to accomplish the same thing outside of DT. Josh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joshua Henderson Subject: Re: [PATCH 12/14] DEVICETREE: Add bindings for PIC32 SDHC host controller Date: Wed, 25 Nov 2015 22:16:32 -0700 Message-ID: <565695B0.8090704@microchip.com> References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-13-git-send-email-joshua.henderson@microchip.com> <20151122215737.GA5285@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151122215737.GA5285@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Andrei Pistirica , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Rob, On 11/22/2015 2:57 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:24PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica >> >> Document the devicetree bindings for the SDHC peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson >> --- >> .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> new file mode 100644 >> index 0000000..f16388c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> @@ -0,0 +1,24 @@ >> +* Microchip PIC32 SDHCI Controller >> + >> +This file documents differences between the core properties in mmc.txt >> +and the properties used by the sdhci-pic32 driver. >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-sdhci" >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for data and command lines >> + >> +Optional properties: >> +- no-1-8-v: 1.8V voltage selection not supported > > There's a standard property for this one. > Correct. This is indeed a standard property that should not be here. There is currently discussion to avoid using this property anyway. >> +- piomode: disable DMA support > > Proably this one too IIRC. > We will be dropping this. There are other ways to accomplish the same thing outside of DT. Josh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html