From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
Peter Lieven <pl@kamp.de>, Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct
Date: Wed, 25 Nov 2015 22:19:19 -0700 [thread overview]
Message-ID: <56569657.6090909@redhat.com> (raw)
In-Reply-To: <1448514335-15988-14-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On 11/25/2015 10:05 PM, Fam Zheng wrote:
> The "flags" bit mask is expanded to two booleans, "data" and "zero";
> "bs" is replaced with "filename" string.
>
> Refactor the merge conditions in img_map() into entry_mergable().
s/mergable/mergeable/ here and in the patch body
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> qapi/block-core.json | 27 ++++++++++++++++++++
> qemu-img.c | 71 +++++++++++++++++++++++++++++++---------------------
> 2 files changed, 69 insertions(+), 29 deletions(-)
>
With the spelling fix,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-26 5:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 5:05 [Qemu-devel] [PATCH v3 00/15] qemu-img map: Allow driver to return file of the allocated block Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 01/15] block: Add "file" output parameter to block status query functions Fam Zheng
2015-11-30 8:38 ` Stefan Hajnoczi
2015-11-30 9:09 ` Fam Zheng
2015-12-01 9:25 ` Stefan Hajnoczi
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 02/15] qcow: Assign bs->file->bs to file in qcow_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 03/15] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 04/15] raw: Assign bs to file in raw_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 06/15] parallels: Assign bs->file->bs to file in parallels_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 07/15] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 08/15] sheepdog: Assign bs to file in sd_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 11/15] vmdk: Return extent's file in bdrv_get_block_status Fam Zheng
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 12/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status Fam Zheng
2015-11-26 5:21 ` Eric Blake
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct Fam Zheng
2015-11-26 5:19 ` Eric Blake [this message]
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 14/15] qemu-img: Use QAPI visitor to generate JSON Fam Zheng
2015-12-10 22:09 ` Eric Blake
2015-11-26 5:05 ` [Qemu-devel] [PATCH v3 15/15] iotests: Add "qemu-img map" test for VMDK extents Fam Zheng
2015-11-30 8:43 ` [Qemu-devel] [PATCH v3 00/15] qemu-img map: Allow driver to return file of the allocated block Stefan Hajnoczi
2015-12-01 9:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56569657.6090909@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.