From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbbKZGgj (ORCPT ); Thu, 26 Nov 2015 01:36:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:38769 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750718AbbKZGgg (ORCPT ); Thu, 26 Nov 2015 01:36:36 -0500 Subject: Re: [PATCH] target: xen-scsiback: Return proper -Exx instead of -1. To: Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <1448479486-5719-1-git-send-email-konrad.wilk@oracle.com> From: Juergen Gross Message-ID: <5656A871.5000405@suse.com> Date: Thu, 26 Nov 2015 07:36:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448479486-5719-1-git-send-email-konrad.wilk@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/15 20:24, Konrad Rzeszutek Wilk wrote: > We could return EINVAL but EBUSY (or EALREADY?)is more appropiate. > > CC: jgross@suse.com > Signed-off-by: Konrad Rzeszutek Wilk While it doesn't really matter it's cleaner. Reviewed-by: Juergen Gross > --- > drivers/xen/xen-scsiback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c > index 43bcae8..286e3da 100644 > --- a/drivers/xen/xen-scsiback.c > +++ b/drivers/xen/xen-scsiback.c > @@ -800,7 +800,7 @@ static int scsiback_init_sring(struct vscsibk_info *info, grant_ref_t ring_ref, > int err; > > if (info->irq) > - return -1; > + return -EBUSY; > > err = xenbus_map_ring_valloc(info->dev, &ring_ref, 1, &area); > if (err) >