Re: [PATCH] cryptodev: mark experimental state

[Panu Matilainen <pmatilai@redhat.com>]

On 11/26/2015 09:39 AM, Panu Matilainen wrote:
> On 11/25/2015 07:38 PM, Thomas Monjalon wrote:
>> The crypto API is in an early state.
>> It requires more discussions and experiments to declare it stable,
>> as discussed in http://dpdk.org/ml/archives/dev/2015-November/028634.html
>>
>> A documentation section will be required in the guides.
>>
>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>> ---
> [...]
>> --- a/config/common_bsdapp
>> +++ b/config/common_bsdapp
>> @@ -310,6 +310,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
>>
>>   #
>>   # Compile generic crypto device library
>> +# EXPERIMENTAL: API may change without prior notice
>>   #
>>   CONFIG_RTE_LIBRTE_CRYPTODEV=y
>>   CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
>> diff --git a/config/common_linuxapp b/config/common_linuxapp
>> index eaad8d6..2866986 100644
>> --- a/config/common_linuxapp
>> +++ b/config/common_linuxapp
>> @@ -319,6 +319,7 @@ CONFIG_RTE_PMD_PACKET_PREFETCH=y
>>
>>   #
>>   # Compile generic crypto device library
>> +# EXPERIMENTAL: API may change without prior notice
>>   #
>>   CONFIG_RTE_LIBRTE_CRYPTODEV=y
>>   CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
> [...]
>
> I think an experimental library which declares itself exempt from the
> ABI policy should not be compiled by default. That way anybody wanting
> to try it out will be forced to notice the experimental status.
>
> More generally / longer term, perhaps there should be a
> CONFIG_RTE_EXPERIMENTAL which wraps all experimental features and
> defaults to off.

On a related note, librte_mbuf_offload cannot be built if 
CONFIG_RTE_LIBRTE_CRYPTODEV is disabled. Which seems to suggest its (at 
least currently) so tightly couple to cryptodev that perhaps it too 
should be marked experimental and default to off.

	- Panu -