From mboxrd@z Thu Jan 1 00:00:00 1970 From: salil.mehta@huawei.com (Salil Mehta) Date: Thu, 26 Nov 2015 08:19:26 +0000 Subject: [PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver In-Reply-To: References: <1447966706-16219-1-git-send-email-salil.mehta@huawei.com> <1447966706-16219-4-git-send-email-salil.mehta@huawei.com> Message-ID: <5656C08E.2010105@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/22/2015 8:49 AM, Yuval Mintz wrote: >> +static void hns_ae_set_tso_stats(struct hnae_handle *handle, int >> +enable) { >> + struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle); >> + >> + hns_ppe_set_tso_enable(ppe_cb, enable); } > Style issues? I could not see the code style issue menioned above in earlier submitted patch. Looks like I am misssing something here! +static void hns_ae_set_tso_stats(struct hnae_handle *handle, int enable) +{ + struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle); + + hns_ppe_set_tso_enable(ppe_cb, enable); +} + > >> +void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) { >> + dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value); } >> + > Likewise Same in above case. Hope I am not missing anything. #include "hns_dsaf_ppe.h" +void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) +{ + dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value); +} + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5656C08E.2010105@huawei.com> Date: Thu, 26 Nov 2015 08:19:26 +0000 From: Salil Mehta MIME-Version: 1.0 Subject: Re: [PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver References: <1447966706-16219-1-git-send-email-salil.mehta@huawei.com> <1447966706-16219-4-git-send-email-salil.mehta@huawei.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit To: Yuval Mintz , David Miller , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "paul.gortmaker@windriver.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "arnd@arndb.de" , "liguozhu@hisilicon.com" , "yisen.zhuang@huawei.com" , "dingtianhong@huawei.com" , "zhangfei.gao@linaro.org" , "huangdaode@hisilicon.com" , "kenneth-lee-2012@foxmail.com" , "mehta.salil.lnk@gmail.com" , "xuwei5@hisilicon.com" , "lisheng011@huawei.com" , "devicetree@vger.kernel.org" , linux-kernel , "linux-arm-kernel@lists.infradead.org" , netdev , "linuxarm@huawei.com" List-ID: On 11/22/2015 8:49 AM, Yuval Mintz wrote: >> +static void hns_ae_set_tso_stats(struct hnae_handle *handle, int >> +enable) { >> + struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle); >> + >> + hns_ppe_set_tso_enable(ppe_cb, enable); } > Style issues? I could not see the code style issue menioned above in earlier submitted patch. Looks like I am misssing something here! +static void hns_ae_set_tso_stats(struct hnae_handle *handle, int enable) +{ + struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle); + + hns_ppe_set_tso_enable(ppe_cb, enable); +} + > >> +void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) { >> + dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value); } >> + > Likewise Same in above case. Hope I am not missing anything. #include "hns_dsaf_ppe.h" +void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) +{ + dsaf_set_dev_bit(ppe_cb, PPEV2_CFG_TSO_EN_REG, 0, !!value); +} +