All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mason <slash.tmp@free.fr>
To: stable@vger.kernel.org
Cc: Russell King <linux@arm.linux.org.uk>
Subject: Patches for arch/arm/mm/cache-l2x0.c
Date: Thu, 26 Nov 2015 09:54:36 +0100	[thread overview]
Message-ID: <5656C8CC.7030202@free.fr> (raw)

Hello,

Over the past few months, I wrote board-support code based on kernel v4.2
and things worked as expected.

Then I had to rebase to a LTS kernel (I used v4.1.13) and something broke
in the L2 cache setup. Apparently, Russell King did a lot of fixing and
cleaning up between v4.1 and v4.2

I cherry-picked the following 5 patches, and my 4.1 kernel works again:

346248a2d1e3a815297125c1347d90dafcc51990 ARM: l2c: avoid passing auxiliary control register through enable method
 arch/arm/mm/cache-l2x0.c | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)
dc63c0733050996143a82f2b095fc378a04274f0 ARM: l2c: only unlock caches if NS_LOCKDOWN bit is set
 arch/arm/mm/cache-l2x0.c | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
7787be2a74dc618bf32348a0f588eebf7ebe0a06 ARM: l2c: clean up l2c_configure()
 arch/arm/mm/cache-l2x0.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)
8f80afa16002e9b4784dc1d51c48f95f52838cfb ARM: l2c: write auxiliary control register first
 arch/arm/mm/cache-l2x0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
9749167eec6a057122b7a1ab2193abd079645aba ARM: l2c: restore the behaviour documented above l2c_enable()
 arch/arm/mm/cache-l2x0.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)


The problem is that my system runs Linux in NS (non-secure) mode, and there
are a bunch of instructions that Linux can't use in that mode.

I suspect the crash comes from trying to unconditionally unlock the caches,
thus patch dc63c0733050.

But 9749167eec6a and 8f80afa16002 also look like good candidates for
back-porting to v4.1

What do you think?

Regards.

             reply	other threads:[~2015-11-26  8:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26  8:54 Mason [this message]
2015-12-01  8:56 ` Patches for arch/arm/mm/cache-l2x0.c Mason
2015-12-01 12:59   ` Russell King - ARM Linux
2015-12-01 14:11     ` Mason
2015-12-01 14:36       ` Rob Herring
2015-12-01 15:05         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5656C8CC.7030202@free.fr \
    --to=slash.tmp@free.fr \
    --cc=linux@arm.linux.org.uk \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.